From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KSU7L-0003md-Gc
	for qemu-devel@nongnu.org; Mon, 11 Aug 2008 05:55:11 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KSU7K-0003kr-Df
	for qemu-devel@nongnu.org; Mon, 11 Aug 2008 05:55:10 -0400
Received: from [199.232.76.173] (port=52954 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KSU7K-0003kZ-6Z
	for qemu-devel@nongnu.org; Mon, 11 Aug 2008 05:55:10 -0400
Received: from smtp.ctxuk.citrix.com ([62.200.22.115]:43126
	helo=SMTP.EU.CITRIX.COM)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <samuel.thibault@labri.fr>) id 1KSU7J-0007Sl-Kp
	for qemu-devel@nongnu.org; Mon, 11 Aug 2008 05:55:09 -0400
Received: from samy by implementation.famille.thibault.fr with local (Exim
	4.69) (envelope-from <samuel.thibault@labri.fr>) id 1KSU7H-0001Cr-Dl
	for qemu-devel@nongnu.org; Mon, 11 Aug 2008 11:55:07 +0200
Date: Mon, 11 Aug 2008 10:54:57 +0100
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
Subject: Re: [Qemu-devel] [RFC, PATCH] Add -Wstrict-prototypes,
	maybe later -Wmissing-prototypes
Message-ID: <20080811095457.GA4499@implementation.uk.xensource.com>
References: <f43fc5580808081022l28c9bd7bs45cfe8a94e32e308@mail.gmail.com>
	<489DE0C7.9000505@codemonkey.ws>
	<f43fc5580808101133r28b4343di4b25404067c13552@mail.gmail.com>
	<489FEFA3.3040105@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <489FEFA3.3040105@redhat.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Gerd Hoffmann, le Mon 11 Aug 2008 09:52:03 +0200, a écrit :
> > The warning is generated because the definition of "handler" should
> > also describe the parameters and not use the old () style. But in this
> > case, they can vary:
> > static void do_help(const char *name)
> > static void do_quit(void)
> [ ... ]
> 
> > I don't have a good plan how to fix this, proposals are welcome.
> > Changing all handlers to use va_args to just silence a gcc warning
> > sounds like overkill.
> 
> Using a union maybe?

That should be the right thing yes.

Samuel