From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KSYmQ-0007ko-A5 for qemu-devel@nongnu.org; Mon, 11 Aug 2008 10:53:54 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KSYmP-0007jW-Ha for qemu-devel@nongnu.org; Mon, 11 Aug 2008 10:53:53 -0400 Received: from [199.232.76.173] (port=46613 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KSYmP-0007jE-BM for qemu-devel@nongnu.org; Mon, 11 Aug 2008 10:53:53 -0400 Received: from mail.codesourcery.com ([65.74.133.4]:39283) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KSYmO-0007Gh-OW for qemu-devel@nongnu.org; Mon, 11 Aug 2008 10:53:53 -0400 From: Paul Brook Subject: Re: [Qemu-devel] [RFC, PATCH] Add -Wstrict-prototypes, maybe later -Wmissing-prototypes Date: Mon, 11 Aug 2008 15:53:48 +0100 References: <48A04ACD.5090900@codemonkey.ws> <48A05150.2040405@qumranet.com> In-Reply-To: <48A05150.2040405@qumranet.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200808111553.48624.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org > > You could just switch void (*handler)() to void *handler. > > Function pointers might be wider than data pointers. I'm pretty sure this isn't true on any current system. On some targets you end up using a function descriptor, but it should still work. > void (*handler)(const char **args) This seems like a reasonable idea. None of this code is performance critical. Paul