From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KSbd4-00038v-Vw
	for qemu-devel@nongnu.org; Mon, 11 Aug 2008 13:56:27 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KSbd0-00031L-Lo
	for qemu-devel@nongnu.org; Mon, 11 Aug 2008 13:56:25 -0400
Received: from [199.232.76.173] (port=42238 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KSbd0-00031A-I0
	for qemu-devel@nongnu.org; Mon, 11 Aug 2008 13:56:22 -0400
Received: from mail2.shareable.org ([80.68.89.115]:40145)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <jamie@shareable.org>) id 1KSbcz-00015R-QY
	for qemu-devel@nongnu.org; Mon, 11 Aug 2008 13:56:21 -0400
Received: from jamie by mail2.shareable.org with local (Exim 4.63)
	(envelope-from <jamie@shareable.org>) id 1KSbcw-0006qe-P0
	for qemu-devel@nongnu.org; Mon, 11 Aug 2008 18:56:18 +0100
Date: Mon, 11 Aug 2008 18:56:18 +0100
From: Jamie Lokier <jamie@shareable.org>
Subject: Re: [Qemu-devel] [PATCH] report read/write errors to IDE guest driver
	as ECC errorsj
Message-ID: <20080811175618.GA25463@shareable.org>
References: <20080805115506.GR4478@implementation.uk.xensource.com>
	<48990BC6.1050503@codemonkey.ws> <20080806092822.GC9055@redhat.com>
	<18592.27928.201904.615457@mariner.uk.xensource.com>
	<20080811170123.GU4499@implementation.uk.xensource.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080811170123.GU4499@implementation.uk.xensource.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Samuel Thibault wrote:
> Actually no, see the thread
> "ext3 seems to ignore ECC errors"
> http://marc.info/?l=linux-kernel&m=121786230719154&w=2
> 
> > Pausing the guest denies the guest the ability to take whatever action
> > it really wants to.
> 
> Sure, but I'm afraid of e.g. guests that would handle it by thinking
> "bad sector, let's mark it as such and try another one".

Yes, there are guests which queue writes which must be ordered, too,
and if an early one fails, they still submit the later ones.

It would be good if QEMU, having failed one write due to its metadata
issues, could fail _all_ subsequent writes to that disk until told
it's ok.  No point having a few scattershot sectors written.

-- Jamie