qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Samuel Thibault <samuel.thibault@eu.citrix.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC, PATCH] Host AIO support detection, OpenBSD host support
Date: Tue, 12 Aug 2008 22:17:31 +0100	[thread overview]
Message-ID: <20080812211731.GP4468@implementation> (raw)
In-Reply-To: <f43fc5580808121145u483ef7b8l6cb86165d259cf93@mail.gmail.com>

For BSD, you may need the patch below as well (from the xen repo)

changeset:   15970:04cc0e22a20a 
user:        Keir Fraser <keir@xensource.com> 
date:        Thu Sep 27 16:36:23 2007 +0100 
files:       tools/ioemu/audio/audio.c tools/ioemu/audio/mixeng.c tools/ioemu/audio/ossaudio.c tools/ioemu/block-raw.c tools/ioemu/block-vvfat.c tools/ioemu/bswap.h tools/ioemu/cutils.c tools/ioemu/monitor.c tools/ioemu/osdep.h tools/ioemu/target-i386-dm/exec-dm.c tools/ioemu/usb-linux.c tools/ioemu/vl.c tools/ioemu/vl.h tools/ioemu/vnc.c 
description: 
ioemu: Fixes for BSD. 
Signed-off-by: Christoph Egger <Christoph.Egger@amd.com> 

Samuel


I don't know why this one was done, it looks a bit odd.

diff --git a/audio/mixeng.c b/audio/mixeng.c
index b668c52..f4b8003 100644
--- a/audio/mixeng.c
+++ b/audio/mixeng.c
@@ -146,6 +146,7 @@
 #undef SHIFT
 
 t_sample *mixeng_conv[2][2][2][3] = {
+#ifndef _BSD
     {
         {
             {
@@ -198,9 +199,11 @@ t_sample *mixeng_conv[2][2][2][3] = {
             }
         }
     }
+#endif /* !_BSD */
 };
 
 f_sample *mixeng_clip[2][2][2][3] = {
+#ifndef _BSD
     {
         {
             {
@@ -253,6 +256,7 @@ f_sample *mixeng_clip[2][2][2][3] = {
             }
         }
     }
+#endif /* !_BSD */
 };
 
 /*



Possibly related to the hunk above, something like improper endian
detection?

diff --git a/bswap.h b/bswap.h
index 523d805..fd589da 100644
--- a/bswap.h
+++ b/bswap.h
@@ -5,6 +5,11 @@
 
 #include <inttypes.h>
 
+#ifdef _BSD
+#include <sys/endian.h>
+#include <sys/types.h>
+#else
+
 #ifdef HAVE_BYTESWAP_H
 #include <byteswap.h>
 #else
@@ -73,6 +78,8 @@ static inline void bswap64s(uint64_t *s)
     *s = bswap64(*s);
 }
 
+#endif /* _BSD */
+
 #if defined(WORDS_BIGENDIAN)
 #define be_bswap(v, size) (v)
 #define le_bswap(v, size) bswap ## size(v)

      parent reply	other threads:[~2008-08-12 21:17 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-12 18:45 [Qemu-devel] [RFC, PATCH] Host AIO support detection, OpenBSD host support Blue Swirl
2008-08-12 19:46 ` Anthony Liguori
2008-08-12 19:56   ` Todd T. Fries
2008-08-12 20:08     ` Anthony Liguori
2008-08-13 16:53     ` Blue Swirl
2008-08-13 16:48   ` Blue Swirl
2008-08-13 17:50     ` Anthony Liguori
2008-08-13 21:48     ` malc
2008-08-15 20:05       ` Blue Swirl
2008-08-15 20:29         ` Todd T. Fries
2008-08-16 16:26         ` malc
2008-08-16 16:36           ` Blue Swirl
2008-08-17 20:44             ` malc
2008-08-16  9:33       ` Blue Swirl
2008-08-12 21:07 ` Samuel Thibault
2008-08-12 21:17 ` Samuel Thibault [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080812211731.GP4468@implementation \
    --to=samuel.thibault@eu.citrix.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).