qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Todd T. Fries" <qemu-devel@email.fries.net>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC, PATCH] Host AIO support detection, OpenBSD host support
Date: Fri, 15 Aug 2008 15:29:43 -0500	[thread overview]
Message-ID: <20080815202943.GA11001@fries.net> (raw)
In-Reply-To: <f43fc5580808151305j7079e945n2f919f8f8409901a@mail.gmail.com>

Actually, the problem is that some driver lists (NetBSD in particular)
were changed to
	list="<a> <b> <c>"
while others (OpenBSD in particular) were left with
	list="a b c"

fun!
-- 
Todd Fries .. todd@fries.net

 _____________________________________________
|                                             \  1.636.410.0632 (voice)
| Free Daemon Consulting, LLC                 \  1.405.227.9094 (voice)
| http://FreeDaemonConsulting.com             \  1.866.792.3418 (FAX)
| "..in support of free software solutions."  \          250797 (FWD)
|                                             \
 \\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\
                                                 
              37E7 D3EB 74D0 8D66 A68D  B866 0326 204E 3F42 004A
                        http://todd.fries.net/pgp.txt

Penned by Blue Swirl on 20080815 23:05.40, we have:
| On 8/14/08, malc <av1474@comtv.ru> wrote:
| > On Wed, 13 Aug 2008, Blue Swirl wrote:
| >
| >
| > > On 8/12/08, Anthony Liguori <anthony@codemonkey.ws> wrote:
| > >
| > > > Blue Swirl wrote:
| > > >
| > > >
| > > > > Here are two patches, loosely based on patches in OpenBSD ports system
| > > > > that enable compiling Qemu. The first patch makes AIO use conditional
| > > > > on host AIO support. The second one adjusts various include files etc.
| > > > >
| > > > > I'd like to commit both of these, is that OK?
| > > > >
| > > > >
| > > > >
| > > >
| > > >  The first patch is fine but the second patch has some bogus things in
| > it.
| > > >
| > >
| > > Thanks for the review. I removed the unneeded parts, made a separate
| > > patch for fixing OSS selection, and added a configure option for AIO
| > > as requested by Samuel Thibault.
| > >
| >
| >  Thanks for the OSS bits, i have committed slightly modified patch that
| >  takes all possible drivers into consideration.
| 
| Great, but there is a bug in your commit, *) case seems to be checked
| before oss|sdl... case gets into play so the error is still present:
| 
| Error: Unknown driver 'oss' selected
| Possible drivers are: oss sdl esd
| 

  reply	other threads:[~2008-08-15 20:31 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-12 18:45 [Qemu-devel] [RFC, PATCH] Host AIO support detection, OpenBSD host support Blue Swirl
2008-08-12 19:46 ` Anthony Liguori
2008-08-12 19:56   ` Todd T. Fries
2008-08-12 20:08     ` Anthony Liguori
2008-08-13 16:53     ` Blue Swirl
2008-08-13 16:48   ` Blue Swirl
2008-08-13 17:50     ` Anthony Liguori
2008-08-13 21:48     ` malc
2008-08-15 20:05       ` Blue Swirl
2008-08-15 20:29         ` Todd T. Fries [this message]
2008-08-16 16:26         ` malc
2008-08-16 16:36           ` Blue Swirl
2008-08-17 20:44             ` malc
2008-08-16  9:33       ` Blue Swirl
2008-08-12 21:07 ` Samuel Thibault
2008-08-12 21:17 ` Samuel Thibault

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080815202943.GA11001@fries.net \
    --to=qemu-devel@email.fries.net \
    --cc=qemu-devel@nongnu.org \
    --cc=todd@fries.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).