From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KV2S9-0003nC-5x
	for qemu-devel@nongnu.org; Mon, 18 Aug 2008 06:59:13 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KV2S8-0003ms-9F
	for qemu-devel@nongnu.org; Mon, 18 Aug 2008 06:59:12 -0400
Received: from [199.232.76.173] (port=47009 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KV2S8-0003mp-52
	for qemu-devel@nongnu.org; Mon, 18 Aug 2008 06:59:12 -0400
Received: from smtp.eu.citrix.com ([62.200.22.115]:27904)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <samuel.thibault@labri.fr>) id 1KV2S7-0000DQ-QS
	for qemu-devel@nongnu.org; Mon, 18 Aug 2008 06:59:11 -0400
Received: from samy by implementation.famille.thibault.fr with local (Exim
	4.69) (envelope-from <samuel.thibault@labri.fr>) id 1KV2S8-00089q-JI
	for qemu-devel@nongnu.org; Mon, 18 Aug 2008 12:59:12 +0200
Date: Mon, 18 Aug 2008 11:59:12 +0100
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
Message-ID: <20080818105912.GF4686@implementation.uk.xensource.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
Subject: [Qemu-devel] pty/tty functions for BSD too
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Hello,

In Xen, pty/tty functions are enabled for BSD too, shouldn't we enable
them in upstream qemu too, as patched below?

Samuel

Index: vl.c
===================================================================
--- vl.c	(révision 5022)
+++ vl.c	(copie de travail)
@@ -2466,7 +2466,7 @@
 }
 #endif
 
-#if defined(__linux__) || defined(__sun__)
+#if defined(__linux__) || defined(__sun__) || defined(__NetBSD__) || defined(__OpenBSD__)
 
 typedef struct {
     int fd;
@@ -3816,7 +3816,7 @@
         return qemu_chr_open_pp(filename);
     } else
 #endif
-#if defined(__linux__) || defined(__sun__)
+#if defined(__linux__) || defined(__sun__) || defined(__NetBSD__) || defined(__OpenBSD__)
     if (strstart(filename, "/dev/", NULL)) {
         return qemu_chr_open_tty(filename);
     } else