From: Aurelien Jarno <aurelien@aurel32.net>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] ACPI suspend type field is 3 bits long
Date: Tue, 19 Aug 2008 15:14:31 +0200 [thread overview]
Message-ID: <20080819131431.GA17838@volta.aurel32.net> (raw)
In-Reply-To: <20080626081231.GA31298@minantech.com>
On Thu, Jun 26, 2008 at 11:12:31AM +0300, Gleb Natapov wrote:
> According to ACPI spec table 4-13 suspend type field should be 3 bits
> long.
>
> diff --git a/hw/acpi.c b/hw/acpi.c
> index 1f83dc6..8f08a7e 100644
> --- a/hw/acpi.c
> +++ b/hw/acpi.c
> @@ -152,7 +152,7 @@ static void pm_ioport_writew(void *opaque, uint32_t addr, uint32_t val)
> s->pmcntrl = val & ~(SUS_EN);
> if (val & SUS_EN) {
> /* change suspend type */
> - sus_typ = (val >> 10) & 3;
> + sus_typ = (val >> 10) & 7;
> switch(sus_typ) {
> case 0: /* soft power off */
> qemu_system_shutdown_request();
Thanks, applied.
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' aurel32@debian.org | aurelien@aurel32.net
`- people.debian.org/~aurel32 | www.aurel32.net
prev parent reply other threads:[~2008-08-19 13:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-26 8:12 [Qemu-devel] [PATCH] ACPI suspend type field is 3 bits long Gleb Natapov
2008-08-19 13:14 ` Aurelien Jarno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080819131431.GA17838@volta.aurel32.net \
--to=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).