From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KVRii-0004CK-JW for qemu-devel@nongnu.org; Tue, 19 Aug 2008 09:58:00 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KVRig-00049p-Oa for qemu-devel@nongnu.org; Tue, 19 Aug 2008 09:58:00 -0400 Received: from [199.232.76.173] (port=34775 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KVRig-00049W-6J for qemu-devel@nongnu.org; Tue, 19 Aug 2008 09:57:58 -0400 Received: from hall.aurel32.net ([91.121.138.14]:55875) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KVRif-0002xC-U9 for qemu-devel@nongnu.org; Tue, 19 Aug 2008 09:57:58 -0400 Received: from [80.187.214.109] (helo=volta.aurel32.net) by hall.aurel32.net with esmtpsa (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1KVRic-0006nw-Ux for qemu-devel@nongnu.org; Tue, 19 Aug 2008 15:57:55 +0200 Received: from aurel32 by volta.aurel32.net with local (Exim 4.69) (envelope-from ) id 1KVR2d-0004pQ-Rx for qemu-devel@nongnu.org; Tue, 19 Aug 2008 15:14:31 +0200 Date: Tue, 19 Aug 2008 15:14:31 +0200 From: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH] ACPI suspend type field is 3 bits long Message-ID: <20080819131431.GA17838@volta.aurel32.net> References: <20080626081231.GA31298@minantech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20080626081231.GA31298@minantech.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Thu, Jun 26, 2008 at 11:12:31AM +0300, Gleb Natapov wrote: > According to ACPI spec table 4-13 suspend type field should be 3 bits > long. > > diff --git a/hw/acpi.c b/hw/acpi.c > index 1f83dc6..8f08a7e 100644 > --- a/hw/acpi.c > +++ b/hw/acpi.c > @@ -152,7 +152,7 @@ static void pm_ioport_writew(void *opaque, uint32_t addr, uint32_t val) > s->pmcntrl = val & ~(SUS_EN); > if (val & SUS_EN) { > /* change suspend type */ > - sus_typ = (val >> 10) & 3; > + sus_typ = (val >> 10) & 7; > switch(sus_typ) { > case 0: /* soft power off */ > qemu_system_shutdown_request(); Thanks, applied. -- .''`. Aurelien Jarno | GPG: 1024D/F1BCDB73 : :' : Debian developer | Electrical Engineer `. `' aurel32@debian.org | aurelien@aurel32.net `- people.debian.org/~aurel32 | www.aurel32.net