* [Qemu-devel] [PATCH] ACPI suspend type field is 3 bits long
@ 2008-06-26 8:12 Gleb Natapov
2008-08-19 13:14 ` Aurelien Jarno
0 siblings, 1 reply; 2+ messages in thread
From: Gleb Natapov @ 2008-06-26 8:12 UTC (permalink / raw)
To: qemu-devel
According to ACPI spec table 4-13 suspend type field should be 3 bits
long.
diff --git a/hw/acpi.c b/hw/acpi.c
index 1f83dc6..8f08a7e 100644
--- a/hw/acpi.c
+++ b/hw/acpi.c
@@ -152,7 +152,7 @@ static void pm_ioport_writew(void *opaque, uint32_t addr, uint32_t val)
s->pmcntrl = val & ~(SUS_EN);
if (val & SUS_EN) {
/* change suspend type */
- sus_typ = (val >> 10) & 3;
+ sus_typ = (val >> 10) & 7;
switch(sus_typ) {
case 0: /* soft power off */
qemu_system_shutdown_request();
--
Gleb.
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] ACPI suspend type field is 3 bits long
2008-06-26 8:12 [Qemu-devel] [PATCH] ACPI suspend type field is 3 bits long Gleb Natapov
@ 2008-08-19 13:14 ` Aurelien Jarno
0 siblings, 0 replies; 2+ messages in thread
From: Aurelien Jarno @ 2008-08-19 13:14 UTC (permalink / raw)
To: qemu-devel
On Thu, Jun 26, 2008 at 11:12:31AM +0300, Gleb Natapov wrote:
> According to ACPI spec table 4-13 suspend type field should be 3 bits
> long.
>
> diff --git a/hw/acpi.c b/hw/acpi.c
> index 1f83dc6..8f08a7e 100644
> --- a/hw/acpi.c
> +++ b/hw/acpi.c
> @@ -152,7 +152,7 @@ static void pm_ioport_writew(void *opaque, uint32_t addr, uint32_t val)
> s->pmcntrl = val & ~(SUS_EN);
> if (val & SUS_EN) {
> /* change suspend type */
> - sus_typ = (val >> 10) & 3;
> + sus_typ = (val >> 10) & 7;
> switch(sus_typ) {
> case 0: /* soft power off */
> qemu_system_shutdown_request();
Thanks, applied.
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' aurel32@debian.org | aurelien@aurel32.net
`- people.debian.org/~aurel32 | www.aurel32.net
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-08-19 13:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-26 8:12 [Qemu-devel] [PATCH] ACPI suspend type field is 3 bits long Gleb Natapov
2008-08-19 13:14 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).