From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KWGDw-0004y7-O1 for qemu-devel@nongnu.org; Thu, 21 Aug 2008 15:53:36 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KWGDv-0004xP-3J for qemu-devel@nongnu.org; Thu, 21 Aug 2008 15:53:36 -0400 Received: from [199.232.76.173] (port=36519 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KWGDu-0004xK-UJ for qemu-devel@nongnu.org; Thu, 21 Aug 2008 15:53:34 -0400 Received: from mx1.redhat.com ([66.187.233.31]:59918) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KWGDv-0002Rf-0M for qemu-devel@nongnu.org; Thu, 21 Aug 2008 15:53:35 -0400 Date: Thu, 21 Aug 2008 20:53:30 +0100 From: "Daniel P. Berrange" Subject: Re: [Xen-devel] Re: [Qemu-devel] vnc port selection Message-ID: <20080821195330.GB1531@redhat.com> References: <48AD99CF.6070004@redhat.com> <48ADB43D.9050401@qumranet.com> <48ADB58D.9070409@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <48ADB58D.9070409@codemonkey.ws> Reply-To: "Daniel P. Berrange" , qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Xen Development Mailing List , qemu-devel@nongnu.org On Thu, Aug 21, 2008 at 01:35:57PM -0500, Anthony Liguori wrote: > Avi Kivity wrote: > >Gerd Hoffmann wrote: > >> Hi folks, > >> > >>Xen's qemu-dm version has a '-vncunused' command line switch which asks > >>the internal vnc server to pick any unused tcp port to listen on. The > >>actual port is communicated to the outside world via xenstore. > >> > >>I'm looking for a reasonable way to implement that functionality in > >>upstream qemu. First, I think it shouldn't be a separate command line > >>switch but an option for the existion -vnc switch. Second, we need a > >>way to communicate the port picked which isn't xen-specific. Obvious > >>choice is a monitor info subcommand. > >> > >>Comments? Other suggestions? > >> > >> > > > >Presumably -vncunused is passed by the management application, which > >knows about all domains. Can't it figure out an unused port and pass > >it on? > > An argument for this sort of semantics is that if you just launch > vncserver with no argument, it'll sit on the first unused port. So > people are sort of used to this behavior. > > >Alternatively, have the management application pass an fd denoting the > >socket. > > If you are allocating the ports in the management tool, then just tell > QEMU what port to open up. I don't think you gain anything passing an fd. And it as I mentioned it'll make adding IPv6 support harder. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|