From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KWGkR-0004VN-6s for qemu-devel@nongnu.org; Thu, 21 Aug 2008 16:27:11 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KWGkO-0004TN-PI for qemu-devel@nongnu.org; Thu, 21 Aug 2008 16:27:09 -0400 Received: from [199.232.76.173] (port=50553 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KWGkO-0004T3-Kt for qemu-devel@nongnu.org; Thu, 21 Aug 2008 16:27:08 -0400 Received: from mx1.redhat.com ([66.187.233.31]:42257) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KWGkO-0000QR-2b for qemu-devel@nongnu.org; Thu, 21 Aug 2008 16:27:08 -0400 Date: Thu, 21 Aug 2008 21:26:40 +0100 From: "Daniel P. Berrange" Subject: Re: [Xen-devel] Re: [Qemu-devel] [PATCH 12/13] set vnc password from xenstore. Message-ID: <20080821202640.GH1531@redhat.com> References: <1219336054-15919-1-git-send-email-kraxel@redhat.com> <1219336054-15919-13-git-send-email-kraxel@redhat.com> <48ADCCA2.8050201@codemonkey.ws> <20080821201955.GG1531@redhat.com> <48ADCE91.2070602@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <48ADCE91.2070602@codemonkey.ws> Reply-To: "Daniel P. Berrange" , qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org, Gerd Hoffmann On Thu, Aug 21, 2008 at 03:22:41PM -0500, Anthony Liguori wrote: > Daniel P. Berrange wrote: > >On Thu, Aug 21, 2008 at 03:14:26PM -0500, Anthony Liguori wrote: > > > >>I don't really like this approach. I don't want to have a totally > >>separate management interface just for Xend to use (via xenstore). > >> > >>Can't Xend use the monitor like every other management tool? > >> > > > >If the monitor really isn't sufficient, then I'd suggest allowing an > >open file descriptor to be specified on the -vnc arg, eg > > > > -vnc localhost:3,passwdfd=6 > > > > In general, I strongly dislike passing file descriptors like this. > > >And then let QEMU read the password from this file descriptor. I'd rather > >XenD just used the monitor though - it'll ultimately need to use it anyway > >to perform disk/network hotplug amongst other things. > > > > If there are reasons that Xend doesn't want to interact with the monitor > (for instance, if you want to support monitor redirection), we can > certainly discuss how to enhance the monitor (like having multiple > monitor instances). Ultimately, we need to have everyone use the same > interface to interact with QEMU. Based on my understanding of XenD code & requirements I think it is mostly just a historical accident that it doesn't use the monitor - quite simply when XenD first picked up QEMU there wasn't much of use the monitor could provide. There were no disk/network/vnc commands for it to use, so it did the easiest thing and read the data out of xenstore, since it was there already. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|