From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KWUjt-0000OR-O9
	for qemu-devel@nongnu.org; Fri, 22 Aug 2008 07:23:33 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KWUjq-0000K0-LP
	for qemu-devel@nongnu.org; Fri, 22 Aug 2008 07:23:31 -0400
Received: from [199.232.76.173] (port=50462 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KWUjp-0000JX-Ub
	for qemu-devel@nongnu.org; Fri, 22 Aug 2008 07:23:30 -0400
Received: from smtp.eu.citrix.com ([62.200.22.115]:11311)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <samuel.thibault@labri.fr>) id 1KWU8d-0003DM-0T
	for qemu-devel@nongnu.org; Fri, 22 Aug 2008 06:45:03 -0400
Received: from samy by implementation.famille.thibault.fr with local (Exim
	4.69) (envelope-from <samuel.thibault@labri.fr>) id 1KWU8O-0001oG-KO
	for qemu-devel@nongnu.org; Fri, 22 Aug 2008 12:44:48 +0200
Date: Fri, 22 Aug 2008 11:44:48 +0100
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
Subject: Re: [Qemu-devel] [5063] Parallel Port Direction Fix
Message-ID: <20080822104448.GG4549@implementation.uk.xensource.com>
References: <E1KWSSE-0004w1-J3@cvs.savannah.gnu.org>
	<48AE881E.4060202@bravegnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <48AE881E.4060202@bravegnu.org>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Vijay Kumar, le Fri 22 Aug 2008 15:04:22 +0530, a écrit :
> Aurelien Jarno wrote:
> >Modified: trunk/qemu-char.h
> >===================================================================
> >--- trunk/qemu-char.h	2008-08-21 23:03:15 UTC (rev 5062)
> >+++ trunk/qemu-char.h	2008-08-22 08:57:09 UTC (rev 5063)
> >@@ -27,6 +27,7 @@
> > #define CHR_IOCTL_PP_EPP_READ         9
> > #define CHR_IOCTL_PP_EPP_WRITE_ADDR  10
> > #define CHR_IOCTL_PP_EPP_WRITE       11
> >+#define CHR_IOCTL_PP_DATA_DIR        12
> > 
> > #define CHR_IOCTL_SERIAL_SET_TIOCM   12
> > #define CHR_IOCTL_SERIAL_GET_TIOCM   13
> 
> Jarno, thanks for committing the patch. But it seems that now there are two 
> IOCTL macros with the same value. To be safe we can move 
> CHR_IOCTL_PP_DATA_DIR to 14.

Or we can push the serial ioctls. All the code using it gets recompiled
anyway.

Samuel