From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KWe8U-0001Jr-RI for qemu-devel@nongnu.org; Fri, 22 Aug 2008 17:25:34 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KWe8U-0001JV-8q for qemu-devel@nongnu.org; Fri, 22 Aug 2008 17:25:34 -0400 Received: from [199.232.76.173] (port=59591 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KWe8T-0001JL-Rb for qemu-devel@nongnu.org; Fri, 22 Aug 2008 17:25:33 -0400 Received: from hall.aurel32.net ([91.121.138.14]:44665) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KWe8T-0000xj-Gq for qemu-devel@nongnu.org; Fri, 22 Aug 2008 17:25:33 -0400 Received: from volta.aurel32.net ([2002:52e8:2fb:1:21e:8cff:feb0:693b]) by hall.aurel32.net with esmtpsa (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1KWe8O-0000Zi-9K for qemu-devel@nongnu.org; Fri, 22 Aug 2008 23:25:28 +0200 Received: from aurel32 by volta.aurel32.net with local (Exim 4.69) (envelope-from ) id 1KWe8N-0005kp-LQ for qemu-devel@nongnu.org; Fri, 22 Aug 2008 23:25:27 +0200 Date: Fri, 22 Aug 2008 23:25:27 +0200 From: Aurelien Jarno Subject: Re: [Qemu-devel] [5063] Parallel Port Direction Fix Message-ID: <20080822212527.GA21937@volta.aurel32.net> References: <48AE881E.4060202@bravegnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <48AE881E.4060202@bravegnu.org> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Fri, Aug 22, 2008 at 03:04:22PM +0530, Vijay Kumar wrote: > Aurelien Jarno wrote: >> Modified: trunk/qemu-char.h >> =================================================================== >> --- trunk/qemu-char.h 2008-08-21 23:03:15 UTC (rev 5062) >> +++ trunk/qemu-char.h 2008-08-22 08:57:09 UTC (rev 5063) >> @@ -27,6 +27,7 @@ >> #define CHR_IOCTL_PP_EPP_READ 9 >> #define CHR_IOCTL_PP_EPP_WRITE_ADDR 10 >> #define CHR_IOCTL_PP_EPP_WRITE 11 >> +#define CHR_IOCTL_PP_DATA_DIR 12 >> #define CHR_IOCTL_SERIAL_SET_TIOCM 12 >> #define CHR_IOCTL_SERIAL_GET_TIOCM 13 > > Jarno, thanks for committing the patch. But it seems that now there are two IOCTL macros with the same value. To be safe we can move CHR_IOCTL_PP_DATA_DIR to 14. Oh right, thanks. I have just applied what samuel suggested. > Signed-off-by: Vijay Kumar > > Index: qemu/qemu-char.h > =================================================================== > --- qemu.orig/qemu-char.h 2008-08-22 15:02:12.000000000 +0530 > +++ qemu/qemu-char.h 2008-08-22 15:02:16.000000000 +0530 > @@ -27,11 +27,12 @@ > #define CHR_IOCTL_PP_EPP_READ 9 > #define CHR_IOCTL_PP_EPP_WRITE_ADDR 10 > #define CHR_IOCTL_PP_EPP_WRITE 11 > -#define CHR_IOCTL_PP_DATA_DIR 12 > > #define CHR_IOCTL_SERIAL_SET_TIOCM 12 > #define CHR_IOCTL_SERIAL_GET_TIOCM 13 > > +#define CHR_IOCTL_PP_DATA_DIR 14 > + > #define CHR_TIOCM_CTS 0x020 > #define CHR_TIOCM_CAR 0x040 > #define CHR_TIOCM_DSR 0x100 > > > > -- .''`. Aurelien Jarno | GPG: 1024D/F1BCDB73 : :' : Debian developer | Electrical Engineer `. `' aurel32@debian.org | aurelien@aurel32.net `- people.debian.org/~aurel32 | www.aurel32.net