From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Jamie Lokier <jamie@shareable.org>
Cc: qemu-devel@nongnu.org, Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH] Fix vfork() syscall emulation
Date: Sun, 24 Aug 2008 18:51:52 +0300 [thread overview]
Message-ID: <20080824155148.GA2544@localhost.localdomain> (raw)
In-Reply-To: <20080824144733.GB28033@shareable.org>
[-- Attachment #1: Type: text/plain, Size: 387 bytes --]
On Sun, Aug 24, 2008 at 03:47:33PM +0100, Jamie Lokier wrote:
> Kirill A. Shutemov wrote:
> > - if (flags & CLONE_VM) {
> > + if (!(flags & CLONE_VFORK) && flags & CLONE_VM) {
>
> Parentheses around (flags & CLONE_VM) would be good here.
Agreed. I'll resend patch soon.
--
Regards, Kirill A. Shutemov
+ Belarus, Minsk
+ ALT Linux Team, http://www.altlinux.com/
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2008-08-24 15:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-23 0:18 [Qemu-devel] [PATCH] Fix vfork() syscall emulation Kirill A. Shutemov
2008-08-24 14:47 ` Jamie Lokier
2008-08-24 15:51 ` Kirill A. Shutemov [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-08-24 15:54 Kirill A. Shutemov
2008-09-08 14:03 Kirill A. Shutemov
2008-09-18 15:06 Kirill A. Shutemov
2008-09-20 2:56 ` andrzej zaborowski
2008-09-20 6:45 ` Kirill A. Shutemov
2008-09-20 12:45 ` andrzej zaborowski
2008-09-20 13:11 ` Kirill A. Shutemov
2008-09-20 13:52 ` andrzej zaborowski
2008-09-20 14:20 ` Kirill A. Shutemov
2008-09-20 14:35 ` andrzej zaborowski
2008-09-20 14:38 ` Kirill A. Shutemov
2008-09-20 7:12 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080824155148.GA2544@localhost.localdomain \
--to=kirill@shutemov.name \
--cc=jamie@shareable.org \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).