From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KXHsc-000535-Nr
	for qemu-devel@nongnu.org; Sun, 24 Aug 2008 11:51:50 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KXHsa-00052n-C2
	for qemu-devel@nongnu.org; Sun, 24 Aug 2008 11:51:49 -0400
Received: from [199.232.76.173] (port=51508 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KXHsa-00052k-6h
	for qemu-devel@nongnu.org; Sun, 24 Aug 2008 11:51:48 -0400
Received: from ey-out-1920.google.com ([74.125.78.148]:13744)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kirill@shutemov.name>) id 1KXHsZ-0003n5-QT
	for qemu-devel@nongnu.org; Sun, 24 Aug 2008 11:51:47 -0400
Received: by ey-out-1920.google.com with SMTP id 4so168145eyk.4
	for <qemu-devel@nongnu.org>; Sun, 24 Aug 2008 08:51:45 -0700 (PDT)
Date: Sun, 24 Aug 2008 18:51:52 +0300
From: "Kirill A. Shutemov" <kirill@shutemov.name>
Subject: Re: [Qemu-devel] [PATCH] Fix vfork() syscall emulation
Message-ID: <20080824155148.GA2544@localhost.localdomain>
References: <1219450705-1376-1-git-send-email-kirill@shutemov.name>
	<20080824144733.GB28033@shareable.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="82I3+IH0IqGh5yIs"
Content-Disposition: inline
In-Reply-To: <20080824144733.GB28033@shareable.org>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jamie Lokier <jamie@shareable.org>
Cc: qemu-devel@nongnu.org, Paul Brook <paul@codesourcery.com>


--82I3+IH0IqGh5yIs
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Aug 24, 2008 at 03:47:33PM +0100, Jamie Lokier wrote:
> Kirill A. Shutemov wrote:
> > -    if (flags & CLONE_VM) {
> > +    if (!(flags & CLONE_VFORK) && flags & CLONE_VM) {
>=20
> Parentheses around (flags & CLONE_VM) would be good here.

Agreed. I'll resend patch soon.

--=20
Regards,  Kirill A. Shutemov
 + Belarus, Minsk
 + ALT Linux Team, http://www.altlinux.com/

--82I3+IH0IqGh5yIs
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkixg5QACgkQbWYnhzC5v6r65gCfc0MwYJjQ1ElOfu8UMMbmsgOY
Y04An1F7aL2uZgNOJrKHL4FUCdixac9n
=p6Ov
-----END PGP SIGNATURE-----

--82I3+IH0IqGh5yIs--