From: Gleb Natapov <gleb@qumranet.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 6/6] Pass cpu speed into SM BIOS.
Date: Mon, 25 Aug 2008 12:44:33 +0300 [thread overview]
Message-ID: <20080825094433.GH6192@minantech.com> (raw)
In-Reply-To: <f43fc5580808241114t7caa0163k879a185a14f11eb8@mail.gmail.com>
On Sun, Aug 24, 2008 at 09:14:23PM +0300, Blue Swirl wrote:
> On 8/24/08, Gleb Natapov <gleb@qumranet.com> wrote:
> > +static uint32_t cpu_speed;
>
> 32 bits won't be enough when we get >4GHz CPUs.
>
The value stored there is in MHz. Actually even 32 bits is to
much since SMBIOS specification uses 16 bit for CPU speed.
> +static double get_freq(int divisor, unsigned int cpu)
>
> I'd use uint64_t and throw away the divisor and double math.
>
I've copied this function from another project and didn't want
to change it much in case we will want to use newer version someday.
> On Sparc64, the frequency line in /proc/cpuinfo looks like:
> Cpu0ClkTck : 000000000ee6b280
>
Can somebody with this HW add support for it. I don't want to do changes
which I can't test.
--
Gleb.
next prev parent reply other threads:[~2008-08-25 9:44 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-24 11:32 [Qemu-devel] [PATCH 0/6] Add UUID command-line option Gleb Natapov
2008-08-24 11:33 ` [Qemu-devel] [PATCH 1/6] Use IO port for qemu<->guest BIOS communication Gleb Natapov
2008-08-24 17:39 ` Blue Swirl
2008-08-25 9:48 ` Gleb Natapov
2008-08-24 11:33 ` [Qemu-devel] [PATCH 2/6] Add -uuid command line option Gleb Natapov
2008-08-24 11:33 ` [Qemu-devel] [PATCH 3/6] Add "info uuid" command to monitor Gleb Natapov
2008-08-24 17:43 ` Blue Swirl
2008-08-25 9:46 ` Gleb Natapov
2008-08-24 11:33 ` [Qemu-devel] [PATCH 4/6] Use libuuid if available Gleb Natapov
2008-08-24 17:50 ` Blue Swirl
2008-08-25 9:44 ` Gleb Natapov
2008-08-24 11:33 ` [Qemu-devel] [PATCH 5/6] Add UUID to BIOS configuration info Gleb Natapov
2008-08-24 11:33 ` [Qemu-devel] [PATCH 6/6] Pass cpu speed into SM BIOS Gleb Natapov
2008-08-24 18:14 ` Blue Swirl
2008-08-25 9:44 ` Gleb Natapov [this message]
2008-08-24 12:01 ` [Qemu-devel] [PATCH 0/6] Add UUID command-line option Blue Swirl
2008-08-24 12:24 ` Gleb Natapov
2008-08-24 12:45 ` Blue Swirl
2008-08-24 13:05 ` Gleb Natapov
2008-08-24 13:35 ` Blue Swirl
2008-08-24 14:11 ` Gleb Natapov
2008-08-24 17:17 ` Blue Swirl
2008-08-24 19:23 ` Kevin O'Connor
2008-08-24 13:09 ` Avi Kivity
2008-08-24 13:43 ` Blue Swirl
2008-08-24 13:55 ` Avi Kivity
2008-08-24 16:56 ` Blue Swirl
2008-08-25 9:32 ` Avi Kivity
2008-08-25 14:22 ` Anthony Liguori
2008-08-24 18:50 ` Kevin O'Connor
2008-08-25 9:29 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080825094433.GH6192@minantech.com \
--to=gleb@qumranet.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).