From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KXYdA-00080l-0y
	for qemu-devel@nongnu.org; Mon, 25 Aug 2008 05:45:00 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KXYd9-0007z2-BA
	for qemu-devel@nongnu.org; Mon, 25 Aug 2008 05:44:59 -0400
Received: from [199.232.76.173] (port=46407 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KXYd8-0007yT-Lp
	for qemu-devel@nongnu.org; Mon, 25 Aug 2008 05:44:58 -0400
Received: from il.qumranet.com ([212.179.150.194]:14185)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <gleb@qumranet.com>) id 1KXYd8-0002Bg-AY
	for qemu-devel@nongnu.org; Mon, 25 Aug 2008 05:44:58 -0400
Received: from gleb-debian.qumranet.com (gleb-debian.qumranet.com.qumranet.com
	[172.16.15.143])
	by il.qumranet.com (Postfix) with ESMTP id 3B0C4250310
	for <qemu-devel@nongnu.org>; Mon, 25 Aug 2008 12:44:57 +0300 (IDT)
Date: Mon, 25 Aug 2008 12:44:57 +0300
From: Gleb Natapov <gleb@qumranet.com>
Subject: Re: [Qemu-devel] [PATCH 4/6] Use libuuid if available.
Message-ID: <20080825094457.GI6192@minantech.com>
References: <20080824113258.5652.92531.stgit@gleb-debian.qumranet.com.qumranet.com>
	<20080824113319.5652.30494.stgit@gleb-debian.qumranet.com.qumranet.com>
	<f43fc5580808241050k13245aafsc4cb60930208ff4@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f43fc5580808241050k13245aafsc4cb60930208ff4@mail.gmail.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Sun, Aug 24, 2008 at 08:50:42PM +0300, Blue Swirl wrote:
> On 8/24/08, Gleb Natapov <gleb@qumranet.com> wrote:
> >  +# uuid library
> >  +if test "$uuid" = "yes" ; then
> >  +  `pkg-config uuid 2> /dev/null` || uuid="no"
> >  +fi
> 
> Please implement the probe like ncurses one.
> 
> >  +static int uuid_dont_generate;
> 
> Positive logic would be clearer: generate_uuid = 1;
> 
> >  +#ifdef CONFIG_UUID
> >  +                uuid_dont_generate = 1;
> 
> generate_uuid = 0;
> 
> >  +    if (!uuid_dont_generate)
> >  +        uuid_generate(qemu_uuid);
> 
> if (generate_uuid)
> 
Done.

--
			Gleb.