From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KXd1Z-0002mG-UP for qemu-devel@nongnu.org; Mon, 25 Aug 2008 10:26:30 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KXd1Y-0002kG-Jl for qemu-devel@nongnu.org; Mon, 25 Aug 2008 10:26:29 -0400 Received: from [199.232.76.173] (port=57947 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KXd1Y-0002jy-9f for qemu-devel@nongnu.org; Mon, 25 Aug 2008 10:26:28 -0400 Received: from il.qumranet.com ([212.179.150.194]:21404) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KXd1X-00036m-R9 for qemu-devel@nongnu.org; Mon, 25 Aug 2008 10:26:28 -0400 Received: from gleb-debian.qumranet.com (gleb-debian.qumranet.com.qumranet.com [172.16.15.143]) by il.qumranet.com (Postfix) with ESMTP id 73D4F250310 for ; Mon, 25 Aug 2008 17:26:26 +0300 (IDT) Date: Mon, 25 Aug 2008 17:26:26 +0300 From: Gleb Natapov Subject: Re: [Qemu-devel] [PATCH v2 6/6] Pass cpu speed into SM BIOS. Message-ID: <20080825142626.GP6192@minantech.com> References: <20080825095800.18703.30602.stgit@gleb-debian.qumranet.com.qumranet.com> <20080825095830.18703.14942.stgit@gleb-debian.qumranet.com.qumranet.com> <48B2BEFB.2060002@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <48B2BEFB.2060002@codemonkey.ws> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Mon, Aug 25, 2008 at 09:17:31AM -0500, Anthony Liguori wrote: > Gleb Natapov wrote: >> Signed-off-by: Gleb Natapov >> > > This is the incorrect frequency for a QEMU guest. I'm not sure why this > is included. What does passing the frequency give us? > This is included for two reasons. First one is to demonstrate that proposed interface is extensible. Second is that Micrisoft SVVP test requires this info (and much more) to be set in SMBIOS tables. Using real HW value seams to be better than just provide some default one. Perhaps scale it a little bit before passing to SMBIOS? -- Gleb.