From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KYMLl-00028Q-Lk for qemu-devel@nongnu.org; Wed, 27 Aug 2008 10:50:21 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KYMLj-00027b-7j for qemu-devel@nongnu.org; Wed, 27 Aug 2008 10:50:20 -0400 Received: from [199.232.76.173] (port=41752 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KYMLj-00027X-3d for qemu-devel@nongnu.org; Wed, 27 Aug 2008 10:50:19 -0400 Received: from bsdimp.com ([199.45.160.85]:62230 helo=harmony.bsdimp.com) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KYMLi-0003l2-HR for qemu-devel@nongnu.org; Wed, 27 Aug 2008 10:50:18 -0400 Date: Wed, 27 Aug 2008 08:47:38 -0600 (MDT) Message-Id: <20080827.084738.-674761106.imp@bsdimp.com> Subject: Re: [Qemu-devel] [patch] add byteordered types From: "M. Warner Losh" In-Reply-To: <48B56645.60206@redhat.com> References: <48B53E23.5040107@redhat.com> <200808271456.57273.paul@codesourcery.com> <48B56645.60206@redhat.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, kraxel@redhat.com In message: <48B56645.60206@redhat.com> Gerd Hoffmann writes: : Paul Brook wrote: : > On Wednesday 27 August 2008, Gerd Hoffmann wrote: : >> +static inline le16 write_le16(uint16_t cpu) \ : > : > This is IMHO a bad name for this function. It doesn't write anything. : : I'm not that happy the name too and certainly open for better : suggestions I could use instead of read/write. : : The alternatives I can think of are not very nice either: : : (1) get/set -- same problem as read/write. : (2) make_foo() instead of write_foo() -- "make" is too generic IMHO. : (3) create_foo() instead of write_foo() -- no nice symmetric : replacement for read_foo(). : : better ideas anyone? Using the existing names that linux/FreeBSD/NetBSD/OpenBSD are using? Warner