From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KYIKs-0002UG-6K for qemu-devel@nongnu.org; Wed, 27 Aug 2008 06:33:11 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KYIKo-0002TW-BT for qemu-devel@nongnu.org; Wed, 27 Aug 2008 06:33:07 -0400 Received: from [199.232.76.173] (port=38794 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KYIKl-0002Sq-Uk for qemu-devel@nongnu.org; Wed, 27 Aug 2008 06:33:04 -0400 Received: from mx1.redhat.com ([66.187.233.31]:37584) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KYIKc-00018r-Kv for qemu-devel@nongnu.org; Wed, 27 Aug 2008 06:32:55 -0400 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m7RAVbtY026888 for ; Wed, 27 Aug 2008 06:31:37 -0400 Received: from file.fab.redhat.com (file.fab.redhat.com [10.33.63.6]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m7RAVamt012483 for ; Wed, 27 Aug 2008 06:31:36 -0400 Received: from file.fab.redhat.com (localhost.localdomain [127.0.0.1]) by file.fab.redhat.com (8.13.1/8.13.1) with ESMTP id m7RAVaqJ002925 for ; Wed, 27 Aug 2008 11:31:36 +0100 Received: (from berrange@localhost) by file.fab.redhat.com (8.13.1/8.13.1/Submit) id m7RAVacJ002921 for qemu-devel@nongnu.org; Wed, 27 Aug 2008 11:31:36 +0100 Date: Wed, 27 Aug 2008 11:31:36 +0100 From: "Daniel P. Berrange" Subject: Re: [Qemu-devel] [5076] VNC: Support for ExtendedKeyEvent client message Message-ID: <20080827103136.GF25099@redhat.com> References: <74C8A544-F282-43CF-B33F-1E8972658190@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <74C8A544-F282-43CF-B33F-1E8972658190@suse.de> Reply-To: "Daniel P. Berrange" , qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Wed, Aug 27, 2008 at 12:02:11PM +0200, Alexander Graf wrote: > On Aug 24, 2008, at 1:27 AM, Anthony Liguori wrote: > >static void set_encodings(VncState *vs, int32_t *encodings, size_t > >n_encodings) > >{ > > int i; > >@@ -1105,6 +1124,9 @@ > > case -257: > > vs->has_pointer_type_change = 1; > > break; > >+ case -258: > >+ send_ext_key_event_ack(vs); > >+ break; > > default: > > break; > > } > >@@ -1256,6 +1278,24 @@ > > > > client_cut_text(vs, read_u32(data, 4), data + 8); > > break; > >+ case 255: > >+ if (len == 1) > >+ return 2; > >+ > >+ switch (read_u8(data, 1)) { > >+ case 0: > > How do you standardize VNC protocol extensions? I've been wondering > about this for quite a while as I've got two VNC patches in my queue > myself. > The first one allows the client to send a keyboard layout (so the -k > option could be changed dynamically, mostly because the Java client > can't find symcodes). This is a straightforward new encoding type > The other one implements PNG compression for Tight. In this case you're proposing additions to someone else's existing defined encoding. I don't believe there's a formal process for doing that, and I don't think Tight even has the ability to negotiate further sub-encodings, so you might be out of luck on that score. > I'd really love to have both of them standardized, but where do I need > to apply for an identifier ID? You can request a encoding to be allocated at vnc-list http://www.realvnc.com/mailman/listinfo/vnc-list For it to be any use, you then need to convince at least one server impl, and one client impl to actually support your new encoding. Obviously the server side in this case is the QEMU developers... Anthony and myself are the developers of the GTK-VNC client, so were merely have to agree with ourselves for the client end, and make sure its plays nicely with the QEMU end. The GTK-VNC client is used in Vinagre, virt-viewer, virt-manager and oVirt. If you wan to propose extensions for the client, we have a public mailing list & source repo: http://sourceforge.net/projects/gtk-vnc Regards, Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|