From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [patch 2/2] add default pci subsystem id for all devices.
Date: Wed, 27 Aug 2008 13:10:29 +0100 [thread overview]
Message-ID: <200808271310.30313.paul@codesourcery.com> (raw)
In-Reply-To: <48B3DE05.3000009@redhat.com>
On Tuesday 26 August 2008, Gerd Hoffmann wrote:
> This sets a default PCI subsystem ID for all emulated PCI devices.
> PCI specs require this, so do it. Individual devices can overwrite
> it of course. The defaults are global variables so they can easily
> be changed (before device creation)
This is just asking for trouble. Having devices set magic global variables
before they create the device is a truly horrible API.
Paul
next prev parent reply other threads:[~2008-08-27 12:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-26 10:42 [Qemu-devel] [patch 2/2] add default pci subsystem id for all devices Gerd Hoffmann
2008-08-27 12:10 ` Paul Brook [this message]
2008-08-27 13:12 ` Gerd Hoffmann
2008-08-27 13:52 ` Paul Brook
2008-08-27 14:19 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808271310.30313.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).