From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KYJrN-0005ZM-9E for qemu-devel@nongnu.org; Wed, 27 Aug 2008 08:10:49 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KYJrM-0005ZA-Oz for qemu-devel@nongnu.org; Wed, 27 Aug 2008 08:10:49 -0400 Received: from [199.232.76.173] (port=52933 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KYJrM-0005Z7-L1 for qemu-devel@nongnu.org; Wed, 27 Aug 2008 08:10:48 -0400 Received: from mail.codesourcery.com ([65.74.133.4]:43674) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KYJrM-0002q7-CC for qemu-devel@nongnu.org; Wed, 27 Aug 2008 08:10:48 -0400 From: Paul Brook Subject: Re: [Qemu-devel] [patch 2/2] add default pci subsystem id for all devices. Date: Wed, 27 Aug 2008 13:10:29 +0100 References: <48B3DE05.3000009@redhat.com> In-Reply-To: <48B3DE05.3000009@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200808271310.30313.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gerd Hoffmann On Tuesday 26 August 2008, Gerd Hoffmann wrote: > This sets a default PCI subsystem ID for all emulated PCI devices. > PCI specs require this, so do it. =A0Individual devices can overwrite > it of course. =A0The defaults are global variables so they can easily > be changed (before device creation) This is just asking for trouble. Having devices set magic global variables= =20 before they create the device is a truly horrible API. Paul