* [Qemu-devel] Reset I32_APIC_BASE on system RESET
@ 2008-08-27 13:44 Gleb Natapov
2008-09-02 0:10 ` Aurelien Jarno
0 siblings, 1 reply; 2+ messages in thread
From: Gleb Natapov @ 2008-08-27 13:44 UTC (permalink / raw)
To: qemu-devel
Should be done according to spec.
Signed-off-by: Gleb Natapov <gleb@qumranet.com>
diff --git a/hw/apic.c b/hw/apic.c
index 43d748c..64e75ad 100644
--- a/hw/apic.c
+++ b/hw/apic.c
@@ -869,6 +869,10 @@ static int apic_load(QEMUFile *f, void *opaque, int version_id)
static void apic_reset(void *opaque)
{
APICState *s = opaque;
+
+ s->apicbase = 0xfee00000 |
+ (s->id ? 0 : MSR_IA32_APICBASE_BSP) | MSR_IA32_APICBASE_ENABLE;
+
apic_init_ipi(s);
if (s->id == 0) {
@@ -906,8 +910,6 @@ int apic_init(CPUState *env)
s->id = last_apic_id++;
env->cpuid_apic_id = s->id;
s->cpu_env = env;
- s->apicbase = 0xfee00000 |
- (s->id ? 0 : MSR_IA32_APICBASE_BSP) | MSR_IA32_APICBASE_ENABLE;
apic_reset(s);
--
Gleb.
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] Reset I32_APIC_BASE on system RESET
2008-08-27 13:44 [Qemu-devel] Reset I32_APIC_BASE on system RESET Gleb Natapov
@ 2008-09-02 0:10 ` Aurelien Jarno
0 siblings, 0 replies; 2+ messages in thread
From: Aurelien Jarno @ 2008-09-02 0:10 UTC (permalink / raw)
To: qemu-devel
On Wed, Aug 27, 2008 at 04:44:48PM +0300, Gleb Natapov wrote:
>
> Should be done according to spec.
>
> Signed-off-by: Gleb Natapov <gleb@qumranet.com>
Applied, thanks.
> diff --git a/hw/apic.c b/hw/apic.c
> index 43d748c..64e75ad 100644
> --- a/hw/apic.c
> +++ b/hw/apic.c
> @@ -869,6 +869,10 @@ static int apic_load(QEMUFile *f, void *opaque, int version_id)
> static void apic_reset(void *opaque)
> {
> APICState *s = opaque;
> +
> + s->apicbase = 0xfee00000 |
> + (s->id ? 0 : MSR_IA32_APICBASE_BSP) | MSR_IA32_APICBASE_ENABLE;
> +
> apic_init_ipi(s);
>
> if (s->id == 0) {
> @@ -906,8 +910,6 @@ int apic_init(CPUState *env)
> s->id = last_apic_id++;
> env->cpuid_apic_id = s->id;
> s->cpu_env = env;
> - s->apicbase = 0xfee00000 |
> - (s->id ? 0 : MSR_IA32_APICBASE_BSP) | MSR_IA32_APICBASE_ENABLE;
>
> apic_reset(s);
>
> --
> Gleb.
>
>
>
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' aurel32@debian.org | aurelien@aurel32.net
`- people.debian.org/~aurel32 | www.aurel32.net
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-09-02 0:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-27 13:44 [Qemu-devel] Reset I32_APIC_BASE on system RESET Gleb Natapov
2008-09-02 0:10 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).