From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KYa4z-0002tW-O5 for qemu-devel@nongnu.org; Thu, 28 Aug 2008 01:29:57 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KYa4x-0002sR-RF for qemu-devel@nongnu.org; Thu, 28 Aug 2008 01:29:56 -0400 Received: from [199.232.76.173] (port=52212 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KYa4w-0002rU-L0 for qemu-devel@nongnu.org; Thu, 28 Aug 2008 01:29:55 -0400 Received: from il.qumranet.com ([212.179.150.194]:51490) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KYa4w-0002Hz-Do for qemu-devel@nongnu.org; Thu, 28 Aug 2008 01:29:54 -0400 Received: from gleb-debian.qumranet.com (gleb-debian.qumranet.com.qumranet.com [172.16.15.143]) by il.qumranet.com (Postfix) with ESMTP id 9103A250310 for ; Thu, 28 Aug 2008 08:29:53 +0300 (IDT) Date: Thu, 28 Aug 2008 08:29:53 +0300 From: Gleb Natapov Subject: Re: [Qemu-devel] [PATCH v2 1/6] Use IO port for qemu<->guest BIOS communication. Message-ID: <20080828052953.GC9450@minantech.com> References: <20080825095805.18703.63202.stgit@gleb-debian.qumranet.com.qumranet.com> <48B2C0A1.7040309@codemonkey.ws> <20080825144026.GQ6192@minantech.com> <48B2F373.1020606@codemonkey.ws> <20080826082453.GV6192@minantech.com> <20080827110522.GX6192@minantech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Wed, Aug 27, 2008 at 08:10:49PM +0300, Blue Swirl wrote: > On 8/27/08, Gleb Natapov wrote: > > > > On Tue, Aug 26, 2008 at 07:46:20PM +0300, Blue Swirl wrote: > > > > Is the patch below what you mean? (not tested, but compiles) > > > > > > Yes, but I'd still put the code from the .h file and pc.c to a new .c > > > file, only the keys and function prototypes to .h. > > > > > > > Okey, here is updated one (compiled only) > > I added some missing pieces like static/const keywords, device > save/load and reset, MMIO and Sparc32/64 support. I also renamed some > names for consistency. Thanks! I'll rebase my other patches on this and will test it. -- Gleb.