From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KYoJ5-0007cq-RU
	for qemu-devel@nongnu.org; Thu, 28 Aug 2008 16:41:27 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KYoJ0-0007ZQ-Vi
	for qemu-devel@nongnu.org; Thu, 28 Aug 2008 16:41:27 -0400
Received: from [199.232.76.173] (port=44673 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KYoJ0-0007ZE-QH
	for qemu-devel@nongnu.org; Thu, 28 Aug 2008 16:41:22 -0400
Received: from relay01.mx.bawue.net ([193.7.176.67]:41597)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <ths@networkno.de>) id 1KYoIz-0006jU-GO
	for qemu-devel@nongnu.org; Thu, 28 Aug 2008 16:41:21 -0400
Date: Thu, 28 Aug 2008 22:41:14 +0200
From: Thiemo Seufer <ths@networkno.de>
Subject: Re: [Qemu-devel] [PATCH] usb-linux.c: #define __user to work
	around broken Linux headers
Message-ID: <20080828204114.GD3229@networkno.de>
References: <18614.53575.679530.36194@mariner.uk.xensource.com>
	<48B70534.40103@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <48B70534.40103@codemonkey.ws>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org

Anthony Liguori wrote:
> Ian Jackson wrote:
>> Really we would like to #include <linux/compiler.h> but according
>> to changelogs in xen-unstable, at least FC6R3 doesn't have it.
>>
>> So instead we do this: we  #define __user  ourselves, which is
>> what <linux/compiler.h> does on systems which are not broken.
>>
>> (This change is identical to xen-unstable
>>  11601:ba7487569374378b398a1b134ea108a6a8209b4b.
>>  and qemu-xen 1f153e0706851b43bb5c2083e531fd7b64b75be1.)
>>   
>
> This was applied at one point in time, but then reverted IIRC.  I think  
> Fabrice objected?

It was rejected because distros should fix their broken headers instead.


Thiemo