* [Qemu-devel] [5100] SH4: Convert register moves to TCG
@ 2008-08-28 21:02 Aurelien Jarno
2008-08-28 22:13 ` Paul Brook
0 siblings, 1 reply; 5+ messages in thread
From: Aurelien Jarno @ 2008-08-28 21:02 UTC (permalink / raw)
To: qemu-devel
Revision: 5100
http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5100
Author: aurel32
Date: 2008-08-28 21:02:38 +0000 (Thu, 28 Aug 2008)
Log Message:
-----------
SH4: Convert register moves to TCG
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
Modified Paths:
--------------
trunk/target-sh4/op.c
trunk/target-sh4/translate.c
Modified: trunk/target-sh4/op.c
===================================================================
--- trunk/target-sh4/op.c 2008-08-28 21:02:30 UTC (rev 5099)
+++ trunk/target-sh4/op.c 2008-08-28 21:02:38 UTC (rev 5100)
@@ -401,12 +401,6 @@
RETURN();
}
-void OPPROTO op_movl_rN_rN(void)
-{
- env->gregs[PARAM2] = env->gregs[PARAM1];
- RETURN();
-}
-
void OPPROTO op_ldcl_rMplus_rN_bank(void)
{
env->gregs[PARAM2] = env->gregs[PARAM1];
@@ -550,84 +544,6 @@
RETURN();
}
-void OPPROTO op_movl_T0_rN(void)
-{
- env->gregs[PARAM1] = T0;
- RETURN();
-}
-
-void OPPROTO op_movl_T1_rN(void)
-{
- env->gregs[PARAM1] = T1;
- RETURN();
-}
-
-void OPPROTO op_movb_rN_T0(void)
-{
- T0 = (int32_t) (int8_t) (env->gregs[PARAM1] & 0xff);
- RETURN();
-}
-
-void OPPROTO op_movub_rN_T0(void)
-{
- T0 = env->gregs[PARAM1] & 0xff;
- RETURN();
-}
-
-void OPPROTO op_movw_rN_T0(void)
-{
- T0 = (int32_t) (int16_t) (env->gregs[PARAM1] & 0xffff);
- RETURN();
-}
-
-void OPPROTO op_movuw_rN_T0(void)
-{
- T0 = env->gregs[PARAM1] & 0xffff;
- RETURN();
-}
-
-void OPPROTO op_movl_rN_T0(void)
-{
- T0 = env->gregs[PARAM1];
- RETURN();
-}
-
-void OPPROTO op_movb_rN_T1(void)
-{
- T1 = (int32_t) (int8_t) (env->gregs[PARAM1] & 0xff);
- RETURN();
-}
-
-void OPPROTO op_movub_rN_T1(void)
-{
- T1 = env->gregs[PARAM1] & 0xff;
- RETURN();
-}
-
-void OPPROTO op_movw_rN_T1(void)
-{
- T1 = (int32_t) (int16_t) (env->gregs[PARAM1] & 0xffff);
- RETURN();
-}
-
-void OPPROTO op_movuw_rN_T1(void)
-{
- T1 = env->gregs[PARAM1] & 0xffff;
- RETURN();
-}
-
-void OPPROTO op_movl_rN_T1(void)
-{
- T1 = env->gregs[PARAM1];
- RETURN();
-}
-
-void OPPROTO op_movl_imm_rN(void)
-{
- env->gregs[PARAM2] = PARAM1;
- RETURN();
-}
-
void OPPROTO op_fmov_frN_FT0(void)
{
FT0 = env->fregs[PARAM1];
Modified: trunk/target-sh4/translate.c
===================================================================
--- trunk/target-sh4/translate.c 2008-08-28 21:02:30 UTC (rev 5099)
+++ trunk/target-sh4/translate.c 2008-08-28 21:02:38 UTC (rev 5100)
@@ -78,6 +78,24 @@
done_init = 1;
}
+/* General purpose registers moves. */
+static inline void gen_movl_imm_rN(target_ulong arg, int reg)
+{
+ TCGv tmp = tcg_const_tl(arg);
+ tcg_gen_st_tl(tmp, cpu_env, offsetof(CPUState, gregs[reg]));
+ tcg_temp_free(tmp);
+}
+
+static always_inline void gen_movl_T_rN (TCGv t, int reg)
+{
+ tcg_gen_st_tl(t, cpu_env, offsetof(CPUState, gregs[reg]));
+}
+
+static always_inline void gen_movl_rN_T (TCGv t, int reg)
+{
+ tcg_gen_ld_tl(t, cpu_env, offsetof(CPUState, gregs[reg]));
+}
+
#ifdef CONFIG_USER_ONLY
#define GEN_OP_LD(width, reg) \
@@ -322,29 +340,29 @@
switch (ctx->opcode & 0xf000) {
case 0x1000: /* mov.l Rm,@(disp,Rn) */
- gen_op_movl_rN_T0(REG(B7_4));
- gen_op_movl_rN_T1(REG(B11_8));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
+ gen_movl_rN_T(cpu_T[1], REG(B11_8));
gen_op_addl_imm_T1(B3_0 * 4);
gen_op_stl_T0_T1(ctx);
return;
case 0x5000: /* mov.l @(disp,Rm),Rn */
- gen_op_movl_rN_T0(REG(B7_4));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
gen_op_addl_imm_T0(B3_0 * 4);
gen_op_ldl_T0_T0(ctx);
- gen_op_movl_T0_rN(REG(B11_8));
+ gen_movl_T_rN(cpu_T[0], REG(B11_8));
return;
case 0xe000: /* mov #imm,Rn */
- gen_op_movl_imm_rN(B7_0s, REG(B11_8));
+ gen_movl_imm_rN(B7_0s, REG(B11_8));
return;
case 0x9000: /* mov.w @(disp,PC),Rn */
tcg_gen_movi_tl(cpu_T[0], ctx->pc + 4 + B7_0 * 2);
gen_op_ldw_T0_T0(ctx);
- gen_op_movl_T0_rN(REG(B11_8));
+ gen_movl_T_rN(cpu_T[0], REG(B11_8));
return;
case 0xd000: /* mov.l @(disp,PC),Rn */
tcg_gen_movi_tl(cpu_T[0], (ctx->pc + 4 + B7_0 * 4) & ~3);
gen_op_ldl_T0_T0(ctx);
- gen_op_movl_T0_rN(REG(B11_8));
+ gen_movl_T_rN(cpu_T[0], REG(B11_8));
return;
case 0x7000: /* add #imm,Rn */
gen_op_add_imm_rN(B7_0s, REG(B11_8));
@@ -364,312 +382,324 @@
switch (ctx->opcode & 0xf00f) {
case 0x6003: /* mov Rm,Rn */
- gen_op_movl_rN_T0(REG(B7_4));
- gen_op_movl_T0_rN(REG(B11_8));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
+ gen_movl_T_rN(cpu_T[0], REG(B11_8));
return;
case 0x2000: /* mov.b Rm,@Rn */
- gen_op_movl_rN_T0(REG(B7_4));
- gen_op_movl_rN_T1(REG(B11_8));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
+ gen_movl_rN_T(cpu_T[1], REG(B11_8));
gen_op_stb_T0_T1(ctx);
return;
case 0x2001: /* mov.w Rm,@Rn */
- gen_op_movl_rN_T0(REG(B7_4));
- gen_op_movl_rN_T1(REG(B11_8));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
+ gen_movl_rN_T(cpu_T[1], REG(B11_8));
gen_op_stw_T0_T1(ctx);
return;
case 0x2002: /* mov.l Rm,@Rn */
- gen_op_movl_rN_T0(REG(B7_4));
- gen_op_movl_rN_T1(REG(B11_8));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
+ gen_movl_rN_T(cpu_T[1], REG(B11_8));
gen_op_stl_T0_T1(ctx);
return;
case 0x6000: /* mov.b @Rm,Rn */
- gen_op_movl_rN_T0(REG(B7_4));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
gen_op_ldb_T0_T0(ctx);
- gen_op_movl_T0_rN(REG(B11_8));
+ gen_movl_T_rN(cpu_T[0], REG(B11_8));
return;
case 0x6001: /* mov.w @Rm,Rn */
- gen_op_movl_rN_T0(REG(B7_4));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
gen_op_ldw_T0_T0(ctx);
- gen_op_movl_T0_rN(REG(B11_8));
+ gen_movl_T_rN(cpu_T[0], REG(B11_8));
return;
case 0x6002: /* mov.l @Rm,Rn */
- gen_op_movl_rN_T0(REG(B7_4));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
gen_op_ldl_T0_T0(ctx);
- gen_op_movl_T0_rN(REG(B11_8));
+ gen_movl_T_rN(cpu_T[0], REG(B11_8));
return;
case 0x2004: /* mov.b Rm,@-Rn */
- gen_op_movl_rN_T0(REG(B7_4));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
gen_op_dec1_rN(REG(B11_8)); /* modify register status */
- gen_op_movl_rN_T1(REG(B11_8));
+ gen_movl_rN_T(cpu_T[1], REG(B11_8));
gen_op_inc1_rN(REG(B11_8)); /* recover register status */
gen_op_stb_T0_T1(ctx); /* might cause re-execution */
gen_op_dec1_rN(REG(B11_8)); /* modify register status */
return;
case 0x2005: /* mov.w Rm,@-Rn */
- gen_op_movl_rN_T0(REG(B7_4));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
gen_op_dec2_rN(REG(B11_8));
- gen_op_movl_rN_T1(REG(B11_8));
+ gen_movl_rN_T(cpu_T[1], REG(B11_8));
gen_op_inc2_rN(REG(B11_8));
gen_op_stw_T0_T1(ctx);
gen_op_dec2_rN(REG(B11_8));
return;
case 0x2006: /* mov.l Rm,@-Rn */
- gen_op_movl_rN_T0(REG(B7_4));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
gen_op_dec4_rN(REG(B11_8));
- gen_op_movl_rN_T1(REG(B11_8));
+ gen_movl_rN_T(cpu_T[1], REG(B11_8));
gen_op_inc4_rN(REG(B11_8));
gen_op_stl_T0_T1(ctx);
gen_op_dec4_rN(REG(B11_8));
return;
case 0x6004: /* mov.b @Rm+,Rn */
- gen_op_movl_rN_T0(REG(B7_4));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
gen_op_ldb_T0_T0(ctx);
- gen_op_movl_T0_rN(REG(B11_8));
+ gen_movl_T_rN(cpu_T[0], REG(B11_8));
if ( B11_8 != B7_4 )
gen_op_inc1_rN(REG(B7_4));
return;
case 0x6005: /* mov.w @Rm+,Rn */
- gen_op_movl_rN_T0(REG(B7_4));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
gen_op_ldw_T0_T0(ctx);
- gen_op_movl_T0_rN(REG(B11_8));
+ gen_movl_T_rN(cpu_T[0], REG(B11_8));
if ( B11_8 != B7_4 )
gen_op_inc2_rN(REG(B7_4));
return;
case 0x6006: /* mov.l @Rm+,Rn */
- gen_op_movl_rN_T0(REG(B7_4));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
gen_op_ldl_T0_T0(ctx);
- gen_op_movl_T0_rN(REG(B11_8));
+ gen_movl_T_rN(cpu_T[0], REG(B11_8));
if ( B11_8 != B7_4 )
gen_op_inc4_rN(REG(B7_4));
return;
case 0x0004: /* mov.b Rm,@(R0,Rn) */
- gen_op_movl_rN_T0(REG(B7_4));
- gen_op_movl_rN_T1(REG(B11_8));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
+ gen_movl_rN_T(cpu_T[1], REG(B11_8));
gen_op_add_rN_T1(REG(0));
gen_op_stb_T0_T1(ctx);
return;
case 0x0005: /* mov.w Rm,@(R0,Rn) */
- gen_op_movl_rN_T0(REG(B7_4));
- gen_op_movl_rN_T1(REG(B11_8));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
+ gen_movl_rN_T(cpu_T[1], REG(B11_8));
gen_op_add_rN_T1(REG(0));
gen_op_stw_T0_T1(ctx);
return;
case 0x0006: /* mov.l Rm,@(R0,Rn) */
- gen_op_movl_rN_T0(REG(B7_4));
- gen_op_movl_rN_T1(REG(B11_8));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
+ gen_movl_rN_T(cpu_T[1], REG(B11_8));
gen_op_add_rN_T1(REG(0));
gen_op_stl_T0_T1(ctx);
return;
case 0x000c: /* mov.b @(R0,Rm),Rn */
- gen_op_movl_rN_T0(REG(B7_4));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
gen_op_add_rN_T0(REG(0));
gen_op_ldb_T0_T0(ctx);
- gen_op_movl_T0_rN(REG(B11_8));
+ gen_movl_T_rN(cpu_T[0], REG(B11_8));
return;
case 0x000d: /* mov.w @(R0,Rm),Rn */
- gen_op_movl_rN_T0(REG(B7_4));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
gen_op_add_rN_T0(REG(0));
gen_op_ldw_T0_T0(ctx);
- gen_op_movl_T0_rN(REG(B11_8));
+ gen_movl_T_rN(cpu_T[0], REG(B11_8));
return;
case 0x000e: /* mov.l @(R0,Rm),Rn */
- gen_op_movl_rN_T0(REG(B7_4));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
gen_op_add_rN_T0(REG(0));
gen_op_ldl_T0_T0(ctx);
- gen_op_movl_T0_rN(REG(B11_8));
+ gen_movl_T_rN(cpu_T[0], REG(B11_8));
return;
case 0x6008: /* swap.b Rm,Rn */
- gen_op_movl_rN_T0(REG(B7_4));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
gen_op_swapb_T0();
- gen_op_movl_T0_rN(REG(B11_8));
+ gen_movl_T_rN(cpu_T[0], REG(B11_8));
return;
case 0x6009: /* swap.w Rm,Rn */
- gen_op_movl_rN_T0(REG(B7_4));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
gen_op_swapw_T0();
- gen_op_movl_T0_rN(REG(B11_8));
+ gen_movl_T_rN(cpu_T[0], REG(B11_8));
return;
case 0x200d: /* xtrct Rm,Rn */
- gen_op_movl_rN_T0(REG(B7_4));
- gen_op_movl_rN_T1(REG(B11_8));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
+ gen_movl_rN_T(cpu_T[1], REG(B11_8));
gen_op_xtrct_T0_T1();
- gen_op_movl_T1_rN(REG(B11_8));
+ gen_movl_T_rN(cpu_T[1], REG(B11_8));
return;
case 0x300c: /* add Rm,Rn */
- gen_op_movl_rN_T0(REG(B7_4));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
gen_op_add_T0_rN(REG(B11_8));
return;
case 0x300e: /* addc Rm,Rn */
- gen_op_movl_rN_T0(REG(B7_4));
- gen_op_movl_rN_T1(REG(B11_8));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
+ gen_movl_rN_T(cpu_T[1], REG(B11_8));
gen_op_addc_T0_T1();
- gen_op_movl_T1_rN(REG(B11_8));
+ gen_movl_T_rN(cpu_T[1], REG(B11_8));
return;
case 0x300f: /* addv Rm,Rn */
- gen_op_movl_rN_T0(REG(B7_4));
- gen_op_movl_rN_T1(REG(B11_8));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
+ gen_movl_rN_T(cpu_T[1], REG(B11_8));
gen_op_addv_T0_T1();
- gen_op_movl_T1_rN(REG(B11_8));
+ gen_movl_T_rN(cpu_T[1], REG(B11_8));
return;
case 0x2009: /* and Rm,Rn */
- gen_op_movl_rN_T0(REG(B7_4));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
gen_op_and_T0_rN(REG(B11_8));
return;
case 0x3000: /* cmp/eq Rm,Rn */
- gen_op_movl_rN_T0(REG(B7_4));
- gen_op_movl_rN_T1(REG(B11_8));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
+ gen_movl_rN_T(cpu_T[1], REG(B11_8));
gen_op_cmp_eq_T0_T1();
return;
case 0x3003: /* cmp/ge Rm,Rn */
- gen_op_movl_rN_T0(REG(B7_4));
- gen_op_movl_rN_T1(REG(B11_8));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
+ gen_movl_rN_T(cpu_T[1], REG(B11_8));
gen_op_cmp_ge_T0_T1();
return;
case 0x3007: /* cmp/gt Rm,Rn */
- gen_op_movl_rN_T0(REG(B7_4));
- gen_op_movl_rN_T1(REG(B11_8));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
+ gen_movl_rN_T(cpu_T[1], REG(B11_8));
gen_op_cmp_gt_T0_T1();
return;
case 0x3006: /* cmp/hi Rm,Rn */
- gen_op_movl_rN_T0(REG(B7_4));
- gen_op_movl_rN_T1(REG(B11_8));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
+ gen_movl_rN_T(cpu_T[1], REG(B11_8));
gen_op_cmp_hi_T0_T1();
return;
case 0x3002: /* cmp/hs Rm,Rn */
- gen_op_movl_rN_T0(REG(B7_4));
- gen_op_movl_rN_T1(REG(B11_8));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
+ gen_movl_rN_T(cpu_T[1], REG(B11_8));
gen_op_cmp_hs_T0_T1();
return;
case 0x200c: /* cmp/str Rm,Rn */
- gen_op_movl_rN_T0(REG(B7_4));
- gen_op_movl_rN_T1(REG(B11_8));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
+ gen_movl_rN_T(cpu_T[1], REG(B11_8));
gen_op_cmp_str_T0_T1();
return;
case 0x2007: /* div0s Rm,Rn */
- gen_op_movl_rN_T0(REG(B7_4));
- gen_op_movl_rN_T1(REG(B11_8));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
+ gen_movl_rN_T(cpu_T[1], REG(B11_8));
gen_op_div0s_T0_T1();
return;
case 0x3004: /* div1 Rm,Rn */
- gen_op_movl_rN_T0(REG(B7_4));
- gen_op_movl_rN_T1(REG(B11_8));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
+ gen_movl_rN_T(cpu_T[1], REG(B11_8));
gen_op_div1_T0_T1();
- gen_op_movl_T1_rN(REG(B11_8));
+ gen_movl_T_rN(cpu_T[1], REG(B11_8));
return;
case 0x300d: /* dmuls.l Rm,Rn */
- gen_op_movl_rN_T0(REG(B7_4));
- gen_op_movl_rN_T1(REG(B11_8));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
+ gen_movl_rN_T(cpu_T[1], REG(B11_8));
gen_op_dmulsl_T0_T1();
return;
case 0x3005: /* dmulu.l Rm,Rn */
- gen_op_movl_rN_T0(REG(B7_4));
- gen_op_movl_rN_T1(REG(B11_8));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
+ gen_movl_rN_T(cpu_T[1], REG(B11_8));
gen_op_dmulul_T0_T1();
return;
case 0x600e: /* exts.b Rm,Rn */
- gen_op_movb_rN_T0(REG(B7_4));
- gen_op_movl_T0_rN(REG(B11_8));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
+ tcg_gen_andi_tl(cpu_T[0], cpu_T[0], 0xff);
+ tcg_gen_ext8s_tl(cpu_T[0], cpu_T[0]);
+ gen_movl_T_rN(cpu_T[0], REG(B11_8));
return;
case 0x600f: /* exts.w Rm,Rn */
- gen_op_movw_rN_T0(REG(B7_4));
- gen_op_movl_T0_rN(REG(B11_8));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
+ tcg_gen_andi_tl(cpu_T[0], cpu_T[0], 0xffff);
+ tcg_gen_ext16s_tl(cpu_T[0], cpu_T[0]);
+ gen_movl_T_rN(cpu_T[0], REG(B11_8));
return;
case 0x600c: /* extu.b Rm,Rn */
- gen_op_movub_rN_T0(REG(B7_4));
- gen_op_movl_T0_rN(REG(B11_8));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
+ tcg_gen_andi_tl(cpu_T[0], cpu_T[0], 0xff);
+ gen_movl_T_rN(cpu_T[0], REG(B11_8));
return;
case 0x600d: /* extu.w Rm,Rn */
- gen_op_movuw_rN_T0(REG(B7_4));
- gen_op_movl_T0_rN(REG(B11_8));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
+ tcg_gen_andi_tl(cpu_T[0], cpu_T[0], 0xffff);
+ gen_movl_T_rN(cpu_T[0], REG(B11_8));
return;
case 0x000f: /* mac.l @Rm+,@Rn+ */
- gen_op_movl_rN_T0(REG(B11_8));
+ gen_movl_rN_T(cpu_T[0], REG(B11_8));
gen_op_ldl_T0_T0(ctx);
tcg_gen_mov_tl(cpu_T[0], cpu_T[1]);
- gen_op_movl_rN_T0(REG(B7_4));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
gen_op_ldl_T0_T0(ctx);
gen_op_macl_T0_T1();
gen_op_inc4_rN(REG(B11_8));
gen_op_inc4_rN(REG(B7_4));
return;
case 0x400f: /* mac.w @Rm+,@Rn+ */
- gen_op_movl_rN_T0(REG(B11_8));
+ gen_movl_rN_T(cpu_T[0], REG(B11_8));
gen_op_ldl_T0_T0(ctx);
tcg_gen_mov_tl(cpu_T[0], cpu_T[1]);
- gen_op_movl_rN_T0(REG(B7_4));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
gen_op_ldl_T0_T0(ctx);
gen_op_macw_T0_T1();
gen_op_inc2_rN(REG(B11_8));
gen_op_inc2_rN(REG(B7_4));
return;
case 0x0007: /* mul.l Rm,Rn */
- gen_op_movl_rN_T0(REG(B7_4));
- gen_op_movl_rN_T1(REG(B11_8));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
+ gen_movl_rN_T(cpu_T[1], REG(B11_8));
gen_op_mull_T0_T1();
return;
case 0x200f: /* muls.w Rm,Rn */
- gen_op_movw_rN_T0(REG(B7_4));
- gen_op_movw_rN_T1(REG(B11_8));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
+ tcg_gen_andi_tl(cpu_T[0], cpu_T[0], 0xffff);
+ tcg_gen_ext16s_tl(cpu_T[0], cpu_T[0]);
+ gen_movl_rN_T(cpu_T[1], REG(B11_8));
+ tcg_gen_andi_tl(cpu_T[1], cpu_T[1], 0xffff);
+ tcg_gen_ext16s_tl(cpu_T[1], cpu_T[1]);
gen_op_mulsw_T0_T1();
return;
case 0x200e: /* mulu.w Rm,Rn */
- gen_op_movuw_rN_T0(REG(B7_4));
- gen_op_movuw_rN_T1(REG(B11_8));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
+ tcg_gen_andi_tl(cpu_T[0], cpu_T[0], 0xffff);
+ gen_movl_rN_T(cpu_T[1], REG(B11_8));
+ tcg_gen_andi_tl(cpu_T[1], cpu_T[1], 0xffff);
gen_op_muluw_T0_T1();
return;
case 0x600b: /* neg Rm,Rn */
- gen_op_movl_rN_T0(REG(B7_4));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
gen_op_neg_T0();
- gen_op_movl_T0_rN(REG(B11_8));
+ gen_movl_T_rN(cpu_T[0], REG(B11_8));
return;
case 0x600a: /* negc Rm,Rn */
- gen_op_movl_rN_T0(REG(B7_4));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
gen_op_negc_T0();
- gen_op_movl_T0_rN(REG(B11_8));
+ gen_movl_T_rN(cpu_T[0], REG(B11_8));
return;
case 0x6007: /* not Rm,Rn */
- gen_op_movl_rN_T0(REG(B7_4));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
gen_op_not_T0();
- gen_op_movl_T0_rN(REG(B11_8));
+ gen_movl_T_rN(cpu_T[0], REG(B11_8));
return;
case 0x200b: /* or Rm,Rn */
- gen_op_movl_rN_T0(REG(B7_4));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
gen_op_or_T0_rN(REG(B11_8));
return;
case 0x400c: /* shad Rm,Rn */
- gen_op_movl_rN_T0(REG(B7_4));
- gen_op_movl_rN_T1(REG(B11_8));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
+ gen_movl_rN_T(cpu_T[1], REG(B11_8));
gen_op_shad_T0_T1();
- gen_op_movl_T1_rN(REG(B11_8));
+ gen_movl_T_rN(cpu_T[1], REG(B11_8));
return;
case 0x400d: /* shld Rm,Rn */
- gen_op_movl_rN_T0(REG(B7_4));
- gen_op_movl_rN_T1(REG(B11_8));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
+ gen_movl_rN_T(cpu_T[1], REG(B11_8));
gen_op_shld_T0_T1();
- gen_op_movl_T1_rN(REG(B11_8));
+ gen_movl_T_rN(cpu_T[1], REG(B11_8));
return;
case 0x3008: /* sub Rm,Rn */
- gen_op_movl_rN_T0(REG(B7_4));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
gen_op_sub_T0_rN(REG(B11_8));
return;
case 0x300a: /* subc Rm,Rn */
- gen_op_movl_rN_T0(REG(B7_4));
- gen_op_movl_rN_T1(REG(B11_8));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
+ gen_movl_rN_T(cpu_T[1], REG(B11_8));
gen_op_subc_T0_T1();
- gen_op_movl_T1_rN(REG(B11_8));
+ gen_movl_T_rN(cpu_T[1], REG(B11_8));
return;
case 0x300b: /* subv Rm,Rn */
- gen_op_movl_rN_T0(REG(B7_4));
- gen_op_movl_rN_T1(REG(B11_8));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
+ gen_movl_rN_T(cpu_T[1], REG(B11_8));
gen_op_subv_T0_T1();
- gen_op_movl_T1_rN(REG(B11_8));
+ gen_movl_T_rN(cpu_T[1], REG(B11_8));
return;
case 0x2008: /* tst Rm,Rn */
- gen_op_movl_rN_T0(REG(B7_4));
- gen_op_movl_rN_T1(REG(B11_8));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
+ gen_movl_rN_T(cpu_T[1], REG(B11_8));
gen_op_tst_T0_T1();
return;
case 0x200a: /* xor Rm,Rn */
- gen_op_movl_rN_T0(REG(B7_4));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
gen_op_xor_T0_rN(REG(B11_8));
return;
case 0xf00c: /* fmov {F,D,X}Rm,{F,D,X}Rn - FPSCR: Nothing */
@@ -684,33 +714,33 @@
case 0xf00a: /* fmov {F,D,X}Rm,@Rn - FPSCR: Nothing */
if (ctx->fpscr & FPSCR_SZ) {
gen_op_fmov_drN_DT0(XREG(B7_4));
- gen_op_movl_rN_T1(REG(B11_8));
+ gen_movl_rN_T(cpu_T[1], REG(B11_8));
gen_op_stfq_DT0_T1(ctx);
} else {
gen_op_fmov_frN_FT0(FREG(B7_4));
- gen_op_movl_rN_T1(REG(B11_8));
+ gen_movl_rN_T(cpu_T[1], REG(B11_8));
gen_op_stfl_FT0_T1(ctx);
}
return;
case 0xf008: /* fmov @Rm,{F,D,X}Rn - FPSCR: Nothing */
if (ctx->fpscr & FPSCR_SZ) {
- gen_op_movl_rN_T0(REG(B7_4));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
gen_op_ldfq_T0_DT0(ctx);
gen_op_fmov_DT0_drN(XREG(B11_8));
} else {
- gen_op_movl_rN_T0(REG(B7_4));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
gen_op_ldfl_T0_FT0(ctx);
gen_op_fmov_FT0_frN(FREG(B11_8));
}
return;
case 0xf009: /* fmov @Rm+,{F,D,X}Rn - FPSCR: Nothing */
if (ctx->fpscr & FPSCR_SZ) {
- gen_op_movl_rN_T0(REG(B7_4));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
gen_op_ldfq_T0_DT0(ctx);
gen_op_fmov_DT0_drN(XREG(B11_8));
gen_op_inc8_rN(REG(B7_4));
} else {
- gen_op_movl_rN_T0(REG(B7_4));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
gen_op_ldfl_T0_FT0(ctx);
gen_op_fmov_FT0_frN(FREG(B11_8));
gen_op_inc4_rN(REG(B7_4));
@@ -720,14 +750,14 @@
if (ctx->fpscr & FPSCR_SZ) {
gen_op_dec8_rN(REG(B11_8));
gen_op_fmov_drN_DT0(XREG(B7_4));
- gen_op_movl_rN_T1(REG(B11_8));
+ gen_movl_rN_T(cpu_T[1], REG(B11_8));
gen_op_inc8_rN(REG(B11_8));
gen_op_stfq_DT0_T1(ctx);
gen_op_dec8_rN(REG(B11_8));
} else {
gen_op_dec4_rN(REG(B11_8));
gen_op_fmov_frN_FT0(FREG(B7_4));
- gen_op_movl_rN_T1(REG(B11_8));
+ gen_movl_rN_T(cpu_T[1], REG(B11_8));
gen_op_inc4_rN(REG(B11_8));
gen_op_stfl_FT0_T1(ctx);
gen_op_dec4_rN(REG(B11_8));
@@ -735,12 +765,12 @@
return;
case 0xf006: /* fmov @(R0,Rm),{F,D,X}Rm - FPSCR: Nothing */
if (ctx->fpscr & FPSCR_SZ) {
- gen_op_movl_rN_T0(REG(B7_4));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
gen_op_add_rN_T0(REG(0));
gen_op_ldfq_T0_DT0(ctx);
gen_op_fmov_DT0_drN(XREG(B11_8));
} else {
- gen_op_movl_rN_T0(REG(B7_4));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
gen_op_add_rN_T0(REG(0));
gen_op_ldfl_T0_FT0(ctx);
gen_op_fmov_FT0_frN(FREG(B11_8));
@@ -749,12 +779,12 @@
case 0xf007: /* fmov {F,D,X}Rn,@(R0,Rn) - FPSCR: Nothing */
if (ctx->fpscr & FPSCR_SZ) {
gen_op_fmov_drN_DT0(XREG(B7_4));
- gen_op_movl_rN_T1(REG(B11_8));
+ gen_movl_rN_T(cpu_T[1], REG(B11_8));
gen_op_add_rN_T1(REG(0));
gen_op_stfq_DT0_T1(ctx);
} else {
gen_op_fmov_frN_FT0(FREG(B7_4));
- gen_op_movl_rN_T1(REG(B11_8));
+ gen_movl_rN_T(cpu_T[1], REG(B11_8));
gen_op_add_rN_T1(REG(0));
gen_op_stfl_FT0_T1(ctx);
}
@@ -811,7 +841,7 @@
gen_op_and_imm_rN(B7_0, REG(0));
return;
case 0xcd00: /* and.b #imm,@(R0,GBR) */
- gen_op_movl_rN_T0(REG(0));
+ gen_movl_rN_T(cpu_T[0], REG(0));
gen_op_addl_GBR_T0();
tcg_gen_mov_tl(cpu_T[0], cpu_T[1]);
gen_op_ldub_T0_T0(ctx);
@@ -841,81 +871,81 @@
ctx->flags |= DELAY_SLOT_CONDITIONAL;
return;
case 0x8800: /* cmp/eq #imm,R0 */
- gen_op_movl_rN_T0(REG(0));
+ gen_movl_rN_T(cpu_T[0], REG(0));
gen_op_cmp_eq_imm_T0(B7_0s);
return;
case 0xc400: /* mov.b @(disp,GBR),R0 */
gen_op_stc_gbr_T0();
gen_op_addl_imm_T0(B7_0);
gen_op_ldb_T0_T0(ctx);
- gen_op_movl_T0_rN(REG(0));
+ gen_movl_T_rN(cpu_T[0], REG(0));
return;
case 0xc500: /* mov.w @(disp,GBR),R0 */
gen_op_stc_gbr_T0();
gen_op_addl_imm_T0(B7_0 * 2);
gen_op_ldw_T0_T0(ctx);
- gen_op_movl_T0_rN(REG(0));
+ gen_movl_T_rN(cpu_T[0], REG(0));
return;
case 0xc600: /* mov.l @(disp,GBR),R0 */
gen_op_stc_gbr_T0();
gen_op_addl_imm_T0(B7_0 * 4);
gen_op_ldl_T0_T0(ctx);
- gen_op_movl_T0_rN(REG(0));
+ gen_movl_T_rN(cpu_T[0], REG(0));
return;
case 0xc000: /* mov.b R0,@(disp,GBR) */
gen_op_stc_gbr_T0();
gen_op_addl_imm_T0(B7_0);
tcg_gen_mov_tl(cpu_T[0], cpu_T[1]);
- gen_op_movl_rN_T0(REG(0));
+ gen_movl_rN_T(cpu_T[0], REG(0));
gen_op_stb_T0_T1(ctx);
return;
case 0xc100: /* mov.w R0,@(disp,GBR) */
gen_op_stc_gbr_T0();
gen_op_addl_imm_T0(B7_0 * 2);
tcg_gen_mov_tl(cpu_T[0], cpu_T[1]);
- gen_op_movl_rN_T0(REG(0));
+ gen_movl_rN_T(cpu_T[0], REG(0));
gen_op_stw_T0_T1(ctx);
return;
case 0xc200: /* mov.l R0,@(disp,GBR) */
gen_op_stc_gbr_T0();
gen_op_addl_imm_T0(B7_0 * 4);
tcg_gen_mov_tl(cpu_T[0], cpu_T[1]);
- gen_op_movl_rN_T0(REG(0));
+ gen_movl_rN_T(cpu_T[0], REG(0));
gen_op_stl_T0_T1(ctx);
return;
case 0x8000: /* mov.b R0,@(disp,Rn) */
- gen_op_movl_rN_T0(REG(0));
- gen_op_movl_rN_T1(REG(B7_4));
+ gen_movl_rN_T(cpu_T[0], REG(0));
+ gen_movl_rN_T(cpu_T[1], REG(B7_4));
gen_op_addl_imm_T1(B3_0);
gen_op_stb_T0_T1(ctx);
return;
case 0x8100: /* mov.w R0,@(disp,Rn) */
- gen_op_movl_rN_T0(REG(0));
- gen_op_movl_rN_T1(REG(B7_4));
+ gen_movl_rN_T(cpu_T[0], REG(0));
+ gen_movl_rN_T(cpu_T[1], REG(B7_4));
gen_op_addl_imm_T1(B3_0 * 2);
gen_op_stw_T0_T1(ctx);
return;
case 0x8400: /* mov.b @(disp,Rn),R0 */
- gen_op_movl_rN_T0(REG(B7_4));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
gen_op_addl_imm_T0(B3_0);
gen_op_ldb_T0_T0(ctx);
- gen_op_movl_T0_rN(REG(0));
+ gen_movl_T_rN(cpu_T[0], REG(0));
return;
case 0x8500: /* mov.w @(disp,Rn),R0 */
- gen_op_movl_rN_T0(REG(B7_4));
+ gen_movl_rN_T(cpu_T[0], REG(B7_4));
gen_op_addl_imm_T0(B3_0 * 2);
gen_op_ldw_T0_T0(ctx);
- gen_op_movl_T0_rN(REG(0));
+ gen_movl_T_rN(cpu_T[0], REG(0));
return;
case 0xc700: /* mova @(disp,PC),R0 */
- gen_op_movl_imm_rN(((ctx->pc & 0xfffffffc) + 4 + B7_0 * 4) & ~3,
+ gen_movl_imm_rN(((ctx->pc & 0xfffffffc) + 4 + B7_0 * 4) & ~3,
REG(0));
return;
case 0xcb00: /* or #imm,R0 */
gen_op_or_imm_rN(B7_0, REG(0));
return;
case 0xcf00: /* or.b #imm,@(R0,GBR) */
- gen_op_movl_rN_T0(REG(0));
+ gen_movl_rN_T(cpu_T[0], REG(0));
gen_op_addl_GBR_T0();
tcg_gen_mov_tl(cpu_T[0], cpu_T[1]);
gen_op_ldub_T0_T0(ctx);
@@ -931,7 +961,7 @@
gen_op_tst_imm_rN(B7_0, REG(0));
return;
case 0xcc00: /* tst.b #imm,@(R0,GBR) */
- gen_op_movl_rN_T0(REG(0));
+ gen_movl_rN_T(cpu_T[0], REG(0));
gen_op_addl_GBR_T0();
gen_op_ldub_T0_T0(ctx);
gen_op_tst_imm_T0(B7_0);
@@ -940,7 +970,7 @@
gen_op_xor_imm_rN(B7_0, REG(0));
return;
case 0xce00: /* xor.b #imm,@(R0,GBR) */
- gen_op_movl_rN_T0(REG(0));
+ gen_movl_rN_T(cpu_T[0], REG(0));
gen_op_addl_GBR_T0();
tcg_gen_mov_tl(cpu_T[0], cpu_T[1]);
gen_op_ldub_T0_T0(ctx);
@@ -951,21 +981,23 @@
switch (ctx->opcode & 0xf08f) {
case 0x408e: /* ldc Rm,Rn_BANK */
- gen_op_movl_rN_rN(REG(B11_8), ALTREG(B6_4));
+ gen_movl_rN_T(cpu_T[0], REG(B11_8));
+ gen_movl_T_rN(cpu_T[0], ALTREG(B6_4));
return;
case 0x4087: /* ldc.l @Rm+,Rn_BANK */
- gen_op_movl_rN_T0(REG(B11_8));
+ gen_movl_rN_T(cpu_T[0], REG(B11_8));
gen_op_ldl_T0_T0(ctx);
- gen_op_movl_T0_rN(ALTREG(B6_4));
+ gen_movl_T_rN(cpu_T[0], ALTREG(B6_4));
gen_op_inc4_rN(REG(B11_8));
return;
case 0x0082: /* stc Rm_BANK,Rn */
- gen_op_movl_rN_rN(ALTREG(B6_4), REG(B11_8));
+ gen_movl_rN_T(cpu_T[0], ALTREG(B6_4));
+ gen_movl_T_rN(cpu_T[0], REG(B11_8));
return;
case 0x4083: /* stc.l Rm_BANK,@-Rn */
gen_op_dec4_rN(REG(B11_8));
- gen_op_movl_rN_T1(REG(B11_8));
- gen_op_movl_rN_T0(ALTREG(B6_4));
+ gen_movl_rN_T(cpu_T[1], REG(B11_8));
+ gen_movl_rN_T(cpu_T[0], ALTREG(B6_4));
gen_op_inc4_rN(REG(B11_8));
gen_op_stl_T0_T1(ctx);
gen_op_dec4_rN(REG(B11_8));
@@ -974,61 +1006,61 @@
switch (ctx->opcode & 0xf0ff) {
case 0x0023: /* braf Rn */
- CHECK_NOT_DELAY_SLOT gen_op_movl_rN_T0(REG(B11_8));
+ CHECK_NOT_DELAY_SLOT gen_movl_rN_T(cpu_T[0], REG(B11_8));
gen_op_braf_T0(ctx->pc + 4);
ctx->flags |= DELAY_SLOT;
ctx->delayed_pc = (uint32_t) - 1;
return;
case 0x0003: /* bsrf Rn */
- CHECK_NOT_DELAY_SLOT gen_op_movl_rN_T0(REG(B11_8));
+ CHECK_NOT_DELAY_SLOT gen_movl_rN_T(cpu_T[0], REG(B11_8));
gen_op_bsrf_T0(ctx->pc + 4);
ctx->flags |= DELAY_SLOT;
ctx->delayed_pc = (uint32_t) - 1;
return;
case 0x4015: /* cmp/pl Rn */
- gen_op_movl_rN_T0(REG(B11_8));
+ gen_movl_rN_T(cpu_T[0], REG(B11_8));
gen_op_cmp_pl_T0();
return;
case 0x4011: /* cmp/pz Rn */
- gen_op_movl_rN_T0(REG(B11_8));
+ gen_movl_rN_T(cpu_T[0], REG(B11_8));
gen_op_cmp_pz_T0();
return;
case 0x4010: /* dt Rn */
gen_op_dt_rN(REG(B11_8));
return;
case 0x402b: /* jmp @Rn */
- CHECK_NOT_DELAY_SLOT gen_op_movl_rN_T0(REG(B11_8));
+ CHECK_NOT_DELAY_SLOT gen_movl_rN_T(cpu_T[0], REG(B11_8));
gen_op_jmp_T0();
ctx->flags |= DELAY_SLOT;
ctx->delayed_pc = (uint32_t) - 1;
return;
case 0x400b: /* jsr @Rn */
- CHECK_NOT_DELAY_SLOT gen_op_movl_rN_T0(REG(B11_8));
+ CHECK_NOT_DELAY_SLOT gen_movl_rN_T(cpu_T[0], REG(B11_8));
gen_op_jsr_T0(ctx->pc + 4);
ctx->flags |= DELAY_SLOT;
ctx->delayed_pc = (uint32_t) - 1;
return;
#define LDST(reg,ldnum,ldpnum,ldop,stnum,stpnum,stop,extrald) \
case ldnum: \
- gen_op_movl_rN_T0 (REG(B11_8)); \
+ gen_movl_rN_T (cpu_T[0], REG(B11_8)); \
gen_op_##ldop##_T0_##reg (); \
extrald \
return; \
case ldpnum: \
- gen_op_movl_rN_T0 (REG(B11_8)); \
+ gen_movl_rN_T (cpu_T[0], REG(B11_8)); \
gen_op_ldl_T0_T0 (ctx); \
gen_op_inc4_rN (REG(B11_8)); \
gen_op_##ldop##_T0_##reg (); \
extrald \
return; \
case stnum: \
- gen_op_##stop##_##reg##_T0 (); \
- gen_op_movl_T0_rN (REG(B11_8)); \
+ gen_op_##stop##_##reg##_T0 (); \
+ gen_movl_T_rN (cpu_T[0], REG(B11_8)); \
return; \
case stpnum: \
gen_op_##stop##_##reg##_T0 (); \
gen_op_dec4_rN (REG(B11_8)); \
- gen_op_movl_rN_T1 (REG(B11_8)); \
+ gen_movl_rN_T (cpu_T[1], REG(B11_8)); \
gen_op_inc4_rN (REG(B11_8)); \
gen_op_stl_T0_T1 (ctx); \
gen_op_dec4_rN (REG(B11_8)); \
@@ -1047,23 +1079,23 @@
LDST(fpscr, 0x406a, 0x4066, lds, 0x006a, 0x4062, sts, ctx->bstate =
BS_STOP;)
case 0x00c3: /* movca.l R0,@Rm */
- gen_op_movl_rN_T0(REG(0));
- gen_op_movl_rN_T1(REG(B11_8));
+ gen_movl_rN_T(cpu_T[0], REG(0));
+ gen_movl_rN_T(cpu_T[1], REG(B11_8));
gen_op_stl_T0_T1(ctx);
return;
case 0x0029: /* movt Rn */
gen_op_movt_rN(REG(B11_8));
return;
case 0x0093: /* ocbi @Rn */
- gen_op_movl_rN_T0(REG(B11_8));
+ gen_movl_rN_T(cpu_T[0], REG(B11_8));
gen_op_ldl_T0_T0(ctx);
return;
case 0x00a3: /* ocbp @Rn */
- gen_op_movl_rN_T0(REG(B11_8));
+ gen_movl_rN_T(cpu_T[0], REG(B11_8));
gen_op_ldl_T0_T0(ctx);
return;
case 0x00b3: /* ocbwb @Rn */
- gen_op_movl_rN_T0(REG(B11_8));
+ gen_movl_rN_T(cpu_T[0], REG(B11_8));
gen_op_ldl_T0_T0(ctx);
return;
case 0x0083: /* pref @Rn */
@@ -1109,7 +1141,7 @@
gen_op_shlr16_Rn(REG(B11_8));
return;
case 0x401b: /* tas.b @Rn */
- gen_op_movl_rN_T0(REG(B11_8));
+ gen_movl_rN_T(cpu_T[0], REG(B11_8));
tcg_gen_mov_tl(cpu_T[0], cpu_T[1]);
gen_op_ldub_T0_T0(ctx);
gen_op_cmp_eq_imm_T0(0);
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [5100] SH4: Convert register moves to TCG
2008-08-28 21:02 [Qemu-devel] [5100] SH4: Convert register moves to TCG Aurelien Jarno
@ 2008-08-28 22:13 ` Paul Brook
2008-08-28 23:23 ` Aurelien Jarno
0 siblings, 1 reply; 5+ messages in thread
From: Paul Brook @ 2008-08-28 22:13 UTC (permalink / raw)
To: qemu-devel; +Cc: Aurelien Jarno
On Thursday 28 August 2008, Aurelien Jarno wrote:
> +static always_inline void gen_movl_T_rN (TCGv t, int reg)
> +{
> + tcg_gen_st_tl(t, cpu_env, offsetof(CPUState, gregs[reg]));
The preferred way of doing this is to have TCG variables for common (possibly
all?) registers. See e.g. m68k or sparc.
Paul
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [5100] SH4: Convert register moves to TCG
2008-08-28 22:13 ` Paul Brook
@ 2008-08-28 23:23 ` Aurelien Jarno
2008-08-29 0:12 ` Paul Brook
2008-08-29 10:46 ` Thiemo Seufer
0 siblings, 2 replies; 5+ messages in thread
From: Aurelien Jarno @ 2008-08-28 23:23 UTC (permalink / raw)
To: qemu-devel
On Thu, Aug 28, 2008 at 11:13:42PM +0100, Paul Brook wrote:
> On Thursday 28 August 2008, Aurelien Jarno wrote:
> > +static always_inline void gen_movl_T_rN (TCGv t, int reg)
> > +{
> > + tcg_gen_st_tl(t, cpu_env, offsetof(CPUState, gregs[reg]));
>
> The preferred way of doing this is to have TCG variables for common (possibly
> all?) registers. See e.g. m68k or sparc.
>
Until now I have used MIPS as an example, it copies CPU registers to TCG
variables. As you pointed, m68k and sparc use direct access to CPU
registers through TCG variables.
I wonder in which way what your propose is better? It seems easier to write,
but what about the runtime speed?
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' aurel32@debian.org | aurelien@aurel32.net
`- people.debian.org/~aurel32 | www.aurel32.net
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [5100] SH4: Convert register moves to TCG
2008-08-28 23:23 ` Aurelien Jarno
@ 2008-08-29 0:12 ` Paul Brook
2008-08-29 10:46 ` Thiemo Seufer
1 sibling, 0 replies; 5+ messages in thread
From: Paul Brook @ 2008-08-29 0:12 UTC (permalink / raw)
To: qemu-devel; +Cc: Aurelien Jarno
On Friday 29 August 2008, Aurelien Jarno wrote:
> On Thu, Aug 28, 2008 at 11:13:42PM +0100, Paul Brook wrote:
> > On Thursday 28 August 2008, Aurelien Jarno wrote:
> > > +static always_inline void gen_movl_T_rN (TCGv t, int reg)
> > > +{
> > > + tcg_gen_st_tl(t, cpu_env, offsetof(CPUState, gregs[reg]));
> >
> > The preferred way of doing this is to have TCG variables for common
> > (possibly all?) registers. See e.g. m68k or sparc.
>
> Until now I have used MIPS as an example, it copies CPU registers to TCG
> variables. As you pointed, m68k and sparc use direct access to CPU
> registers through TCG variables.
>
> I wonder in which way what your propose is better? It seems easier to
> write, but what about the runtime speed?
I'm guessing that with current tcg there's not a lot of difference. Using
variables (like sparc/m68k) gives scope for better/easier code generation in
the future, and makes debug dumps look prettier.
Paul
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [5100] SH4: Convert register moves to TCG
2008-08-28 23:23 ` Aurelien Jarno
2008-08-29 0:12 ` Paul Brook
@ 2008-08-29 10:46 ` Thiemo Seufer
1 sibling, 0 replies; 5+ messages in thread
From: Thiemo Seufer @ 2008-08-29 10:46 UTC (permalink / raw)
To: Aurelien Jarno; +Cc: qemu-devel
Aurelien Jarno wrote:
> On Thu, Aug 28, 2008 at 11:13:42PM +0100, Paul Brook wrote:
> > On Thursday 28 August 2008, Aurelien Jarno wrote:
> > > +static always_inline void gen_movl_T_rN (TCGv t, int reg)
> > > +{
> > > + tcg_gen_st_tl(t, cpu_env, offsetof(CPUState, gregs[reg]));
> >
> > The preferred way of doing this is to have TCG variables for common (possibly
> > all?) registers. See e.g. m68k or sparc.
> >
>
> Until now I have used MIPS as an example, it copies CPU registers to TCG
> variables. As you pointed, m68k and sparc use direct access to CPU
> registers through TCG variables.
For MIPS I tried to keep thing similiar to dyngen when both TCG and
dyngen were used. Then I converted a few places to use TCG variables
but had no time to finish the job.
> I wonder in which way what your propose is better? It seems easier to write,
> but what about the runtime speed?
TCG variables are (potentially) better.
Thiemo
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2008-08-29 10:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-28 21:02 [Qemu-devel] [5100] SH4: Convert register moves to TCG Aurelien Jarno
2008-08-28 22:13 ` Paul Brook
2008-08-28 23:23 ` Aurelien Jarno
2008-08-29 0:12 ` Paul Brook
2008-08-29 10:46 ` Thiemo Seufer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).