qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Vince Weaver <vince@csl.cornell.edu>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [5123] Fix y register loads and stores
Date: Mon, 1 Sep 2008 19:05:45 -0400 (EDT)	[thread overview]
Message-ID: <20080901190455.M84611@stanley.csl.cornell.edu> (raw)
In-Reply-To: <20080901182340.H84348@stanley.csl.cornell.edu>


> So something is wrong with the sign extension.  Unfortunately I won't have 
> time to look into this more until tomorrow, but I wanted to just get this out 
> there.

I did have time to look at it in the end.

Here's a patch that fixes my test case.  I'll have to look at the sparcv9 
manual closer to make sure it's the right thing to do.

Vince

--- ./target-sparc/translate.c.orig	2008-09-01 19:03:10.000000000 -0400
+++ ./target-sparc/translate.c	2008-09-01 19:02:54.000000000 -0400
@@ -793,8 +793,8 @@
      r_temp = tcg_temp_new(TCG_TYPE_I64);
      r_temp2 = tcg_temp_new(TCG_TYPE_I64);

-    tcg_gen_ext_tl_i64(r_temp, src2);
-    tcg_gen_ext_tl_i64(r_temp2, src1);
+    tcg_gen_ext_i32_i64(r_temp, src2);
+    tcg_gen_ext_i32_i64(r_temp2, src1);
      tcg_gen_mul_i64(r_temp2, r_temp, r_temp2);

      tcg_gen_shri_i64(r_temp, r_temp2, 32);

  reply	other threads:[~2008-09-01 23:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-01 19:35 [Qemu-devel] [5123] Fix y register loads and stores Blue Swirl
2008-09-01 21:39 ` Vince Weaver
2008-09-01 22:28   ` Vince Weaver
2008-09-01 23:05     ` Vince Weaver [this message]
2008-09-02 16:55       ` Blue Swirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080901190455.M84611@stanley.csl.cornell.edu \
    --to=vince@csl.cornell.edu \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).