From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Kajuv-0006JD-2U
	for qemu-devel@nongnu.org; Wed, 03 Sep 2008 00:24:29 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Kajut-0006Iu-7D
	for qemu-devel@nongnu.org; Wed, 03 Sep 2008 00:24:28 -0400
Received: from [199.232.76.173] (port=35994 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Kajut-0006Im-0i
	for qemu-devel@nongnu.org; Wed, 03 Sep 2008 00:24:27 -0400
Received: from mta23.gyao.ne.jp ([125.63.38.249]:63544 helo=mx.gate01.com)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <lethal@linux-sh.org>) id 1Kajus-0007Dk-JF
	for qemu-devel@nongnu.org; Wed, 03 Sep 2008 00:24:26 -0400
Received: from [124.34.33.190] (helo=master.linux-sh.org)
	by pop54.isp.us-com.jp with esmtp (Mail 4.69) id 1Kajuo-0002Pv-Py
	for qemu-devel@nongnu.org; Wed, 03 Sep 2008 13:24:22 +0900
Received: from localhost (unknown [127.0.0.1])
	by master.linux-sh.org (Postfix) with ESMTP id 4FAAC63754
	for <qemu-devel@nongnu.org>; Wed,  3 Sep 2008 04:23:59 +0000 (UTC)
Received: from master.linux-sh.org ([127.0.0.1])
	by localhost (master.linux-sh.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 6Mh+oYQXVa0C for <qemu-devel@nongnu.org>;
	Wed,  3 Sep 2008 13:23:59 +0900 (JST)
Date: Wed, 3 Sep 2008 13:23:58 +0900
From: Paul Mundt <lethal@linux-sh.org>
Subject: Re: [Qemu-devel] [5132] SH4: fix a regression introduced in r5122
Message-ID: <20080903042358.GA5322@linux-sh.org>
References: <E1KaRSr-0002SB-ES@cvs.savannah.gnu.org>
	<200809030101.17786.s@informa.pl>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200809030101.17786.s@informa.pl>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Wed, Sep 03, 2008 at 01:01:17AM +0200, Sebastian Kaliszewski wrote:
> Dnia Tuesday 02 of September 2008, Aurelien Jarno napisa??:
> > Revision: 5132
> >           http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5132
> > Author:   aurel32
> > Date:     2008-09-02 08:42:16 +0000 (Tue, 02 Sep 2008)
> >
> > Log Message:
> > -----------
> > SH4: fix a regression introduced in r5122
> >
> > Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> >
> > Modified Paths:
> > --------------
> >     trunk/target-sh4/translate.c
> >
> > Modified: trunk/target-sh4/translate.c
> > ===================================================================
> > --- trunk/target-sh4/translate.c	2008-09-02 00:09:35 UTC (rev 5131)
> > +++ trunk/target-sh4/translate.c	2008-09-02 08:42:16 UTC (rev 5132)
> > @@ -1392,7 +1392,7 @@
> >  	tcg_gen_qemu_st32 (cpu_##reg, addr, ctx->memidx);	\
> >  	tcg_temp_free(addr);					\
> >  	tcg_gen_subi_i32(REG(B11_8), REG(B11_8), 4);		\
> > -    }
> > +    }								\
> >      return;
> >  	LDST(gbr,  0x401e, 0x4017, 0x0012, 0x4013)
> >  	LDST(vbr,  0x402e, 0x4027, 0x0022, 0x4023)
> 
> Hello!
> 
> Hmm, this is just adding one space, are you sure the right thing go commited
> 
Read again. It's adding a \ so the return; is factored in to the macro.