From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KavMF-0007Yj-0j for qemu-devel@nongnu.org; Wed, 03 Sep 2008 12:37:27 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KavM9-0007Qx-QC for qemu-devel@nongnu.org; Wed, 03 Sep 2008 12:37:25 -0400 Received: from [199.232.76.173] (port=56139 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KavM9-0007Qn-8u for qemu-devel@nongnu.org; Wed, 03 Sep 2008 12:37:21 -0400 Received: from mx1.redhat.com ([66.187.233.31]:40703) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KavM8-0007CI-RS for qemu-devel@nongnu.org; Wed, 03 Sep 2008 12:37:20 -0400 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m83GbJkM007545 for ; Wed, 3 Sep 2008 12:37:19 -0400 Received: from file.fab.redhat.com (file.fab.redhat.com [10.33.63.6]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m83GbIw4014285 for ; Wed, 3 Sep 2008 12:37:18 -0400 Received: from file.fab.redhat.com (localhost.localdomain [127.0.0.1]) by file.fab.redhat.com (8.13.1/8.13.1) with ESMTP id m83GbI1w004448 for ; Wed, 3 Sep 2008 17:37:18 +0100 Received: (from berrange@localhost) by file.fab.redhat.com (8.13.1/8.13.1/Submit) id m83GbIRE004444 for qemu-devel@nongnu.org; Wed, 3 Sep 2008 17:37:18 +0100 Date: Wed, 3 Sep 2008 17:37:18 +0100 From: "Daniel P. Berrange" Subject: Re: [Qemu-devel] [PATCH] sdl shared buffer support Message-ID: <20080903163717.GO20308@redhat.com> References: <48B813FA.7010206@eu.citrix.com> <48BE68E8.7050404@eu.citrix.com> <48BEB743.5050805@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <48BEB743.5050805@eu.citrix.com> Reply-To: "Daniel P. Berrange" , qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Wed, Sep 03, 2008 at 05:11:47PM +0100, Stefano Stabellini wrote: > Stefano Stabellini wrote: > > > Blue Swirl wrote: > > > >> This function is broken if BGR-ness of the display is not equal to > >> emulated device BGR-ness. > >> > > > > good catch! > > I am going to send an updated version of this and the opengl patch soon > > to fix the issue. > > > > I replied to this email a little too fast: reading vga.c and > vga_template.h again more carefully it occurred to me that the guest is > always RGB, only the host can set the sdl display to BGR. > Hence we don't need to handle this case in sdl_setdata, because if there > is any difference in depth or subpixel ordering between host and guest, > is up to SDL_BlitSurface to solve it. > > But there is a similar issue that I wasn't handling: guest big endian > and host little endian or vice versa. > In fact I need to set different colour masks in sdl setdata according to > the guest endianness. Just to complicate things still further, the endianness of the host running QEMU may not be the same as the endianness of the X server display. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|