From: Aurelien Jarno <aurelien@aurel32.net>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [5157] ppc: fix fpr TCG registers creation
Date: Thu, 4 Sep 2008 19:06:57 +0200 [thread overview]
Message-ID: <20080904170657.GA32441@volta.aurel32.net> (raw)
In-Reply-To: <EBEF845B-A7E9-4D29-BEF7-2DFE1126C64D@googlemail.com>
On Thu, Sep 04, 2008 at 06:43:18PM +0200, Andreas Färber wrote:
>
> Am 04.09.2008 um 17:49 schrieb Aurelien Jarno:
>
>> Modified: trunk/target-ppc/translate.c
>> ===================================================================
>> --- trunk/target-ppc/translate.c 2008-09-04 14:43:54 UTC (rev 5156)
>> +++ trunk/target-ppc/translate.c 2008-09-04 15:49:12 UTC (rev 5157)
>> @@ -141,11 +141,13 @@
>> sprintf(p, "fp%d", i);
>> cpu_fpr[i] = tcg_global_mem_new(TCG_TYPE_I64, TCG_AREG0,
>> offsetof(CPUState, fpr[i]),
>> p);
>> + p += (i < 10) ? 4 : 5;
>>
>> sprintf(p, "avr%dH", i);
>> cpu_avrh[i] = tcg_global_mem_new(TCG_TYPE_I64, TCG_AREG0,
>
> Ouch, thanks for noticing!
>
> Where would I notice this issue btw? (apart from code review)
>
By looking at the debugging log (-d op)
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' aurel32@debian.org | aurelien@aurel32.net
`- people.debian.org/~aurel32 | www.aurel32.net
prev parent reply other threads:[~2008-09-04 17:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-04 15:49 [Qemu-devel] [5157] ppc: fix fpr TCG registers creation Aurelien Jarno
2008-09-04 16:43 ` Andreas Färber
2008-09-04 17:06 ` Aurelien Jarno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080904170657.GA32441@volta.aurel32.net \
--to=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).