[Qemu-devel] [5157] ppc: fix fpr TCG registers creation

[Qemu-devel] [5157] ppc: fix fpr TCG registers creation

[Aurelien Jarno]

Revision: 5157
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5157
Author:   aurel32
Date:     2008-09-04 15:49:12 +0000 (Thu, 04 Sep 2008)

Log Message:
-----------
ppc: fix fpr TCG registers creation

Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>

Modified Paths:
--------------
    trunk/target-ppc/translate.c

Modified: trunk/target-ppc/translate.c
===================================================================
--- trunk/target-ppc/translate.c	2008-09-04 14:43:54 UTC (rev 5156)
+++ trunk/target-ppc/translate.c	2008-09-04 15:49:12 UTC (rev 5157)
@@ -141,11 +141,13 @@
         sprintf(p, "fp%d", i);
         cpu_fpr[i] = tcg_global_mem_new(TCG_TYPE_I64, TCG_AREG0,
                                         offsetof(CPUState, fpr[i]), p);
+        p += (i < 10) ? 4 : 5;
 
         sprintf(p, "avr%dH", i);
         cpu_avrh[i] = tcg_global_mem_new(TCG_TYPE_I64, TCG_AREG0,
                                          offsetof(CPUState, avr[i].u64[0]), p);
         p += (i < 10) ? 6 : 7;
+
         sprintf(p, "avr%dL", i);
         cpu_avrl[i] = tcg_global_mem_new(TCG_TYPE_I64, TCG_AREG0,
                                          offsetof(CPUState, avr[i].u64[1]), p);

Re: [Qemu-devel] [5157] ppc: fix fpr TCG registers creation

[Andreas Färber]

Am 04.09.2008 um 17:49 schrieb Aurelien Jarno:

> Modified: trunk/target-ppc/translate.c
> ===================================================================
> --- trunk/target-ppc/translate.c	2008-09-04 14:43:54 UTC (rev 5156)
> +++ trunk/target-ppc/translate.c	2008-09-04 15:49:12 UTC (rev 5157)
> @@ -141,11 +141,13 @@
>         sprintf(p, "fp%d", i);
>         cpu_fpr[i] = tcg_global_mem_new(TCG_TYPE_I64, TCG_AREG0,
>                                         offsetof(CPUState, fpr[i]),  
> p);
> +        p += (i < 10) ? 4 : 5;
>
>         sprintf(p, "avr%dH", i);
>         cpu_avrh[i] = tcg_global_mem_new(TCG_TYPE_I64, TCG_AREG0,

Ouch, thanks for noticing!

Where would I notice this issue btw? (apart from code review)

Andreas

Re: [Qemu-devel] [5157] ppc: fix fpr TCG registers creation

[Aurelien Jarno]

On Thu, Sep 04, 2008 at 06:43:18PM +0200, Andreas Färber wrote:
>
> Am 04.09.2008 um 17:49 schrieb Aurelien Jarno:
>
>> Modified: trunk/target-ppc/translate.c
>> ===================================================================
>> --- trunk/target-ppc/translate.c	2008-09-04 14:43:54 UTC (rev 5156)
>> +++ trunk/target-ppc/translate.c	2008-09-04 15:49:12 UTC (rev 5157)
>> @@ -141,11 +141,13 @@
>>         sprintf(p, "fp%d", i);
>>         cpu_fpr[i] = tcg_global_mem_new(TCG_TYPE_I64, TCG_AREG0,
>>                                         offsetof(CPUState, fpr[i]),  
>> p);
>> +        p += (i < 10) ? 4 : 5;
>>
>>         sprintf(p, "avr%dH", i);
>>         cpu_avrh[i] = tcg_global_mem_new(TCG_TYPE_I64, TCG_AREG0,
>
> Ouch, thanks for noticing!
>
> Where would I notice this issue btw? (apart from code review)
>

By looking at the debugging log (-d op)


-- 
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   aurel32@debian.org         | aurelien@aurel32.net
   `-    people.debian.org/~aurel32 | www.aurel32.net