From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KbIIS-0003YN-Ea
	for qemu-devel@nongnu.org; Thu, 04 Sep 2008 13:07:04 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KbIIR-0003Xi-CS
	for qemu-devel@nongnu.org; Thu, 04 Sep 2008 13:07:03 -0400
Received: from [199.232.76.173] (port=34077 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KbIIR-0003Xd-4o
	for qemu-devel@nongnu.org; Thu, 04 Sep 2008 13:07:03 -0400
Received: from hall.aurel32.net ([91.121.138.14]:42389)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <aurelien@aurel32.net>)
	id 1KbIIQ-0000fk-G9
	for qemu-devel@nongnu.org; Thu, 04 Sep 2008 13:07:02 -0400
Received: from junta-icatm144570-bada.red.retevision.es ([62.81.118.18]
	helo=volta.aurel32.net)
	by hall.aurel32.net with esmtpsa (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.63) (envelope-from <aurelien@aurel32.net>)
	id 1KbIIO-0007FU-PO
	for qemu-devel@nongnu.org; Thu, 04 Sep 2008 19:07:01 +0200
Received: from aurel32 by volta.aurel32.net with local (Exim 4.69)
	(envelope-from <aurelien@aurel32.net>) id 1KbIIL-0001Xz-SH
	for qemu-devel@nongnu.org; Thu, 04 Sep 2008 19:06:57 +0200
Date: Thu, 4 Sep 2008 19:06:57 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [5157] ppc: fix fpr TCG registers creation
Message-ID: <20080904170657.GA32441@volta.aurel32.net>
References: <E1KbH57-0000XB-6T@cvs.savannah.gnu.org>
	<EBEF845B-A7E9-4D29-BEF7-2DFE1126C64D@googlemail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <EBEF845B-A7E9-4D29-BEF7-2DFE1126C64D@googlemail.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Thu, Sep 04, 2008 at 06:43:18PM +0200, Andreas Färber wrote:
>
> Am 04.09.2008 um 17:49 schrieb Aurelien Jarno:
>
>> Modified: trunk/target-ppc/translate.c
>> ===================================================================
>> --- trunk/target-ppc/translate.c	2008-09-04 14:43:54 UTC (rev 5156)
>> +++ trunk/target-ppc/translate.c	2008-09-04 15:49:12 UTC (rev 5157)
>> @@ -141,11 +141,13 @@
>>         sprintf(p, "fp%d", i);
>>         cpu_fpr[i] = tcg_global_mem_new(TCG_TYPE_I64, TCG_AREG0,
>>                                         offsetof(CPUState, fpr[i]),  
>> p);
>> +        p += (i < 10) ? 4 : 5;
>>
>>         sprintf(p, "avr%dH", i);
>>         cpu_avrh[i] = tcg_global_mem_new(TCG_TYPE_I64, TCG_AREG0,
>
> Ouch, thanks for noticing!
>
> Where would I notice this issue btw? (apart from code review)
>

By looking at the debugging log (-d op)


-- 
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   aurel32@debian.org         | aurelien@aurel32.net
   `-    people.debian.org/~aurel32 | www.aurel32.net