* [Qemu-devel] [5157] ppc: fix fpr TCG registers creation
@ 2008-09-04 15:49 Aurelien Jarno
2008-09-04 16:43 ` Andreas Färber
0 siblings, 1 reply; 3+ messages in thread
From: Aurelien Jarno @ 2008-09-04 15:49 UTC (permalink / raw)
To: qemu-devel
Revision: 5157
http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5157
Author: aurel32
Date: 2008-09-04 15:49:12 +0000 (Thu, 04 Sep 2008)
Log Message:
-----------
ppc: fix fpr TCG registers creation
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
Modified Paths:
--------------
trunk/target-ppc/translate.c
Modified: trunk/target-ppc/translate.c
===================================================================
--- trunk/target-ppc/translate.c 2008-09-04 14:43:54 UTC (rev 5156)
+++ trunk/target-ppc/translate.c 2008-09-04 15:49:12 UTC (rev 5157)
@@ -141,11 +141,13 @@
sprintf(p, "fp%d", i);
cpu_fpr[i] = tcg_global_mem_new(TCG_TYPE_I64, TCG_AREG0,
offsetof(CPUState, fpr[i]), p);
+ p += (i < 10) ? 4 : 5;
sprintf(p, "avr%dH", i);
cpu_avrh[i] = tcg_global_mem_new(TCG_TYPE_I64, TCG_AREG0,
offsetof(CPUState, avr[i].u64[0]), p);
p += (i < 10) ? 6 : 7;
+
sprintf(p, "avr%dL", i);
cpu_avrl[i] = tcg_global_mem_new(TCG_TYPE_I64, TCG_AREG0,
offsetof(CPUState, avr[i].u64[1]), p);
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [5157] ppc: fix fpr TCG registers creation
2008-09-04 15:49 [Qemu-devel] [5157] ppc: fix fpr TCG registers creation Aurelien Jarno
@ 2008-09-04 16:43 ` Andreas Färber
2008-09-04 17:06 ` Aurelien Jarno
0 siblings, 1 reply; 3+ messages in thread
From: Andreas Färber @ 2008-09-04 16:43 UTC (permalink / raw)
To: qemu-devel
Am 04.09.2008 um 17:49 schrieb Aurelien Jarno:
> Modified: trunk/target-ppc/translate.c
> ===================================================================
> --- trunk/target-ppc/translate.c 2008-09-04 14:43:54 UTC (rev 5156)
> +++ trunk/target-ppc/translate.c 2008-09-04 15:49:12 UTC (rev 5157)
> @@ -141,11 +141,13 @@
> sprintf(p, "fp%d", i);
> cpu_fpr[i] = tcg_global_mem_new(TCG_TYPE_I64, TCG_AREG0,
> offsetof(CPUState, fpr[i]),
> p);
> + p += (i < 10) ? 4 : 5;
>
> sprintf(p, "avr%dH", i);
> cpu_avrh[i] = tcg_global_mem_new(TCG_TYPE_I64, TCG_AREG0,
Ouch, thanks for noticing!
Where would I notice this issue btw? (apart from code review)
Andreas
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [5157] ppc: fix fpr TCG registers creation
2008-09-04 16:43 ` Andreas Färber
@ 2008-09-04 17:06 ` Aurelien Jarno
0 siblings, 0 replies; 3+ messages in thread
From: Aurelien Jarno @ 2008-09-04 17:06 UTC (permalink / raw)
To: qemu-devel
On Thu, Sep 04, 2008 at 06:43:18PM +0200, Andreas Färber wrote:
>
> Am 04.09.2008 um 17:49 schrieb Aurelien Jarno:
>
>> Modified: trunk/target-ppc/translate.c
>> ===================================================================
>> --- trunk/target-ppc/translate.c 2008-09-04 14:43:54 UTC (rev 5156)
>> +++ trunk/target-ppc/translate.c 2008-09-04 15:49:12 UTC (rev 5157)
>> @@ -141,11 +141,13 @@
>> sprintf(p, "fp%d", i);
>> cpu_fpr[i] = tcg_global_mem_new(TCG_TYPE_I64, TCG_AREG0,
>> offsetof(CPUState, fpr[i]),
>> p);
>> + p += (i < 10) ? 4 : 5;
>>
>> sprintf(p, "avr%dH", i);
>> cpu_avrh[i] = tcg_global_mem_new(TCG_TYPE_I64, TCG_AREG0,
>
> Ouch, thanks for noticing!
>
> Where would I notice this issue btw? (apart from code review)
>
By looking at the debugging log (-d op)
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' aurel32@debian.org | aurelien@aurel32.net
`- people.debian.org/~aurel32 | www.aurel32.net
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-09-04 17:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-04 15:49 [Qemu-devel] [5157] ppc: fix fpr TCG registers creation Aurelien Jarno
2008-09-04 16:43 ` Andreas Färber
2008-09-04 17:06 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).