From: "Edgar E. Iglesias" <edgar.iglesias@axis.com>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: "Edgar E. Iglesias" <edgar@axis.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] TCG fixes for target-cris
Date: Fri, 5 Sep 2008 15:45:01 +0200 [thread overview]
Message-ID: <20080905134501.GB12335@edgar.se.axis.com> (raw)
In-Reply-To: <20080905124101.GA22225@hall.aurel32.net>
On Fri, Sep 05, 2008 at 02:41:01PM +0200, Aurelien Jarno wrote:
> This patch fixes TCG errors reported on the CRIS target when TCG_DEBUG
> is enabled.
Thanks!
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
Acked-by: Edgar E. Iglesias <edgar@axis.com>
> ---
> target-cris/translate.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target-cris/translate.c b/target-cris/translate.c
> index c43992e..7666cba 100644
> --- a/target-cris/translate.c
> +++ b/target-cris/translate.c
> @@ -1268,7 +1268,7 @@ static inline void t_gen_sext(TCGv d, TCGv s, int size)
> tcg_gen_ext8s_i32(d, s);
> else if (size == 2)
> tcg_gen_ext16s_i32(d, s);
> - else if(d != s)
> + else if(GET_TCGV(d) != GET_TCGV(s))
> tcg_gen_mov_tl(d, s);
> }
>
> @@ -1278,7 +1278,7 @@ static inline void t_gen_zext(TCGv d, TCGv s, int size)
> tcg_gen_ext8u_i32(d, s);
> else if (size == 2)
> tcg_gen_ext16u_i32(d, s);
> - else if (d != s)
> + else if (GET_TCGV(d) != GET_TCGV(s))
> tcg_gen_mov_tl(d, s);
> }
>
> --
> 1.5.6.5
>
>
> --
> .''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
> : :' : Debian developer | Electrical Engineer
> `. `' aurel32@debian.org | aurelien@aurel32.net
> `- people.debian.org/~aurel32 | www.aurel32.net
>
prev parent reply other threads:[~2008-09-05 13:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-05 12:41 [Qemu-devel] [PATCH] TCG fixes for target-cris Aurelien Jarno
2008-09-05 13:45 ` Edgar E. Iglesias [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080905134501.GB12335@edgar.se.axis.com \
--to=edgar.iglesias@axis.com \
--cc=aurelien@aurel32.net \
--cc=edgar@axis.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).