From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KbbcX-0004ue-0r for qemu-devel@nongnu.org; Fri, 05 Sep 2008 09:45:05 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KbbcV-0004s2-Q2 for qemu-devel@nongnu.org; Fri, 05 Sep 2008 09:45:04 -0400 Received: from [199.232.76.173] (port=55692 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KbbcV-0004rm-LR for qemu-devel@nongnu.org; Fri, 05 Sep 2008 09:45:03 -0400 Received: from bart.se.axis.com ([195.60.68.10]:44898) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KbbcW-0000tr-2R for qemu-devel@nongnu.org; Fri, 05 Sep 2008 09:45:04 -0400 Received: from bart.se.axis.com (bart.se.axis.com [127.0.0.1]) by bart.se.axis.com (Postfix) with ESMTP id 5438B63FB4 for ; Fri, 5 Sep 2008 15:45:01 +0200 (CEST) Received: from axis.com (edgar.se.axis.com [10.93.151.1]) by bart.se.axis.com (Postfix) with ESMTP id 3C7AE63FB1 for ; Fri, 5 Sep 2008 15:45:01 +0200 (CEST) Date: Fri, 5 Sep 2008 15:45:01 +0200 From: "Edgar E. Iglesias" Subject: Re: [Qemu-devel] [PATCH] TCG fixes for target-cris Message-ID: <20080905134501.GB12335@edgar.se.axis.com> References: <20080905124101.GA22225@hall.aurel32.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080905124101.GA22225@hall.aurel32.net> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: "Edgar E. Iglesias" , qemu-devel@nongnu.org On Fri, Sep 05, 2008 at 02:41:01PM +0200, Aurelien Jarno wrote: > This patch fixes TCG errors reported on the CRIS target when TCG_DEBUG > is enabled. Thanks! > Signed-off-by: Aurelien Jarno Acked-by: Edgar E. Iglesias > --- > target-cris/translate.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/target-cris/translate.c b/target-cris/translate.c > index c43992e..7666cba 100644 > --- a/target-cris/translate.c > +++ b/target-cris/translate.c > @@ -1268,7 +1268,7 @@ static inline void t_gen_sext(TCGv d, TCGv s, int size) > tcg_gen_ext8s_i32(d, s); > else if (size == 2) > tcg_gen_ext16s_i32(d, s); > - else if(d != s) > + else if(GET_TCGV(d) != GET_TCGV(s)) > tcg_gen_mov_tl(d, s); > } > > @@ -1278,7 +1278,7 @@ static inline void t_gen_zext(TCGv d, TCGv s, int size) > tcg_gen_ext8u_i32(d, s); > else if (size == 2) > tcg_gen_ext16u_i32(d, s); > - else if (d != s) > + else if (GET_TCGV(d) != GET_TCGV(s)) > tcg_gen_mov_tl(d, s); > } > > -- > 1.5.6.5 > > > -- > .''`. Aurelien Jarno | GPG: 1024D/F1BCDB73 > : :' : Debian developer | Electrical Engineer > `. `' aurel32@debian.org | aurelien@aurel32.net > `- people.debian.org/~aurel32 | www.aurel32.net >