[Qemu-devel] Some little fixes on QEMU.

[Qemu-devel] Some little fixes on QEMU.

[carlo.bramix]

[-- Attachment #1: Type: text/plain, Size: 244 bytes --]

Hello,
I did few little fixes to QEMU:
- some vectors can be declared as "const"
- test on CONFIG_VNC_TLS is done for two times while just one is enough.

Attached patch describes the changes in details.

Sincerely,

Carlo Bramini.


[-- Attachment #2: qemu.diff --]
[-- Type: application/octet-stream, Size: 2074 bytes --]

Index: qemu/vnc.c
===================================================================
--- qemu/vnc.c	(revisione 5162)
+++ qemu/vnc.c	(copia locale)
@@ -109,12 +109,10 @@
     VNC_AUTH_VENCRYPT_X509PLAIN = 262,
 };
 
-#if CONFIG_VNC_TLS
 #define X509_CA_CERT_FILE "ca-cert.pem"
 #define X509_CA_CRL_FILE "ca-crl.pem"
 #define X509_SERVER_KEY_FILE "server-key.pem"
 #define X509_SERVER_CERT_FILE "server-cert.pem"
-#endif
 
 #endif /* CONFIG_VNC_TLS */
 
Index: qemu/d3des.c
===================================================================
--- qemu/d3des.c	(revisione 5162)
+++ qemu/d3des.c	(copia locale)
@@ -35,10 +35,10 @@
 
 static unsigned long KnL[32] = { 0L };
 
-static unsigned short bytebit[8]	= {
+static const unsigned short bytebit[8]	= {
 	01, 02, 04, 010, 020, 040, 0100, 0200 };
 
-static unsigned long bigbyte[24] = {
+static const unsigned long bigbyte[24] = {
 	0x800000L,	0x400000L,	0x200000L,	0x100000L,
 	0x80000L,	0x40000L,	0x20000L,	0x10000L,
 	0x8000L,	0x4000L,	0x2000L,	0x1000L,
@@ -48,16 +48,16 @@
 
 /* Use the key schedule specified in the Standard (ANSI X3.92-1981). */
 
-static unsigned char pc1[56] = {
+static const unsigned char pc1[56] = {
 	56, 48, 40, 32, 24, 16,  8,	 0, 57, 49, 41, 33, 25, 17,
 	 9,  1, 58, 50, 42, 34, 26,	18, 10,  2, 59, 51, 43, 35,
 	62, 54, 46, 38, 30, 22, 14,	 6, 61, 53, 45, 37, 29, 21,
 	13,  5, 60, 52, 44, 36, 28,	20, 12,  4, 27, 19, 11,  3 };
 
-static unsigned char totrot[16] = {
+static const unsigned char totrot[16] = {
 	1,2,4,6,8,10,12,14,15,17,19,21,23,25,27,28 };
 
-static unsigned char pc2[48] = {
+static const unsigned char pc2[48] = {
 	13, 16, 10, 23,  0,  4,  2, 27, 14,  5, 20,  9,
 	22, 18, 11,  3, 25,  7, 15,  6, 26, 19, 12,  1,
 	40, 51, 30, 36, 46, 54, 29, 39, 50, 44, 32, 47,
Index: qemu/vgafont.h
===================================================================
--- qemu/vgafont.h	(revisione 5162)
+++ qemu/vgafont.h	(copia locale)
@@ -1,4 +1,4 @@
-static uint8_t vgafont16[256 * 16] = {
+static const uint8_t vgafont16[256 * 16] = {
 
 	/* 0 0x00 '^@' */
 	0x00, /* 00000000 */

Re: [Qemu-devel] Some little fixes on QEMU.

[Aurelien Jarno]

On Fri, Sep 05, 2008 at 04:38:57PM +0200, carlo.bramix wrote:
> Hello,
> I did few little fixes to QEMU:
> - some vectors can be declared as "const"
> - test on CONFIG_VNC_TLS is done for two times while just one is enough.
> 
> Attached patch describes the changes in details.
> 

Patch applied, thanks.

-- 
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   aurel32@debian.org         | aurelien@aurel32.net
   `-    people.debian.org/~aurel32 | www.aurel32.net