From: Gleb Natapov <gleb@qumranet.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 1/6] Use IO port for qemu<->guest BIOS communication.
Date: Mon, 8 Sep 2008 08:39:17 +0300 [thread overview]
Message-ID: <20080908053917.GA5924@minantech.com> (raw)
In-Reply-To: <48C33D89.9000805@codemonkey.ws>
I suppose you are referring to "cpu speed" patch.
> I think this is missing save/restore support. What happens if you do a
> save, move to a different machine, then do a restore, and reboot? The
> guest will see a different value IIUC.
>
I don't think that getting a different value in SMBIOS tables after reboot
is problematic. It may change on real HW too I think. Because of power
saving on a laptop for instance.
> Also, instead of returning 0 on non-linux systems, why not just return
> some fixed value? It's no more "wrong" than returning the host clock
> rate.
>
I am OK with that. What value do you propose?
I'll resent a whole series. Let's move discussion there. And if there is
no more comments about other parts of the series can we apply it finally?
--
Gleb.
next prev parent reply other threads:[~2008-09-08 5:39 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-25 9:58 [Qemu-devel] [PATCH v2 0/6] Add UUID command-line option Gleb Natapov
2008-08-25 9:58 ` [Qemu-devel] [PATCH v2 1/6] Use IO port for qemu<->guest BIOS communication Gleb Natapov
2008-08-25 14:24 ` Anthony Liguori
2008-08-25 14:40 ` Gleb Natapov
2008-08-25 15:01 ` Blue Swirl
2008-08-25 18:01 ` Anthony Liguori
2008-08-25 18:27 ` Blue Swirl
2008-08-26 8:24 ` Gleb Natapov
2008-08-26 16:46 ` Blue Swirl
2008-08-26 19:30 ` Avi Kivity
2008-08-26 19:43 ` Blue Swirl
2008-08-27 8:18 ` Avi Kivity
2008-08-27 11:05 ` Gleb Natapov
2008-08-27 17:10 ` Blue Swirl
2008-08-28 5:29 ` Gleb Natapov
2008-09-07 2:33 ` Anthony Liguori
2008-09-07 9:32 ` Blue Swirl
2008-09-08 5:39 ` Gleb Natapov [this message]
2008-08-25 14:25 ` Anthony Liguori
2008-08-25 14:46 ` Gleb Natapov
2008-08-25 15:37 ` Jamie Lokier
2008-08-25 18:53 ` [Qemu-devel] Re: [PATCH v2 1/6] Use IO port for qemu<->guest BIOScommunication Sebastian Herbszt
2008-08-26 8:17 ` Gleb Natapov
2008-08-25 9:58 ` [Qemu-devel] [PATCH v2 2/6] Add -uuid command line option Gleb Natapov
2008-08-25 9:58 ` [Qemu-devel] [PATCH v2 3/6] Add "info uuid" command to monitor Gleb Natapov
2008-08-25 9:58 ` [Qemu-devel] [PATCH v2 4/6] Use libuuid if available Gleb Natapov
2008-08-25 11:08 ` Andreas Färber
2008-08-25 11:26 ` Gleb Natapov
2008-08-25 11:35 ` Jamie Lokier
2008-08-25 11:45 ` Andreas Färber
2008-08-25 14:03 ` Gleb Natapov
2008-08-25 18:57 ` [Qemu-devel] " Sebastian Herbszt
2008-08-25 9:58 ` [Qemu-devel] [PATCH v2 5/6] Add UUID to BIOS configuration info Gleb Natapov
2008-08-25 9:58 ` [Qemu-devel] [PATCH v2 6/6] Pass cpu speed into SM BIOS Gleb Natapov
2008-08-25 14:17 ` Anthony Liguori
2008-08-25 14:26 ` Gleb Natapov
2008-08-25 19:26 ` [Qemu-devel] " Sebastian Herbszt
2008-08-26 6:23 ` Gleb Natapov
2008-08-27 23:42 ` [Qemu-devel] " Sebastian Herbszt
2008-08-28 5:28 ` Gleb Natapov
2008-08-25 19:15 ` [Qemu-devel] " Sebastian Herbszt
2008-08-26 6:34 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080908053917.GA5924@minantech.com \
--to=gleb@qumranet.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).