From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KcZT9-0002iz-EX
	for qemu-devel@nongnu.org; Mon, 08 Sep 2008 01:39:23 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KcZT8-0002ge-3q
	for qemu-devel@nongnu.org; Mon, 08 Sep 2008 01:39:22 -0400
Received: from [199.232.76.173] (port=48741 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KcZT7-0002gH-UO
	for qemu-devel@nongnu.org; Mon, 08 Sep 2008 01:39:22 -0400
Received: from il.qumranet.com ([212.179.150.194]:42638)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <gleb@qumranet.com>) id 1KcZT7-0005Zr-Fz
	for qemu-devel@nongnu.org; Mon, 08 Sep 2008 01:39:21 -0400
Received: from gleb-debian.qumranet.com (gleb-debian.qumranet.com.qumranet.com
	[172.16.15.143])
	by il.qumranet.com (Postfix) with ESMTP id 30293250310
	for <qemu-devel@nongnu.org>; Mon,  8 Sep 2008 08:39:18 +0300 (IDT)
Date: Mon, 8 Sep 2008 08:39:17 +0300
From: Gleb Natapov <gleb@qumranet.com>
Subject: Re: [Qemu-devel] [PATCH v2 1/6] Use IO port for qemu<->guest BIOS
	communication.
Message-ID: <20080908053917.GA5924@minantech.com>
References: <20080825144026.GQ6192@minantech.com>
	<f43fc5580808250801s3e975006s1e0e99b291291a8e@mail.gmail.com>
	<48B2F373.1020606@codemonkey.ws>
	<f43fc5580808251127m36cec30du40858fb0e731832c@mail.gmail.com>
	<20080826082453.GV6192@minantech.com>
	<f43fc5580808260946t67536b67nb46acc6ed450aa80@mail.gmail.com>
	<20080827110522.GX6192@minantech.com>
	<f43fc5580808271010l2640c69bj58637b607d755d4b@mail.gmail.com>
	<20080828052953.GC9450@minantech.com>
	<48C33D89.9000805@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <48C33D89.9000805@codemonkey.ws>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

I suppose you are referring to "cpu speed" patch. 

> I think this is missing save/restore support.  What happens if you do a  
> save, move to a different machine, then do a restore, and reboot?  The  
> guest will see a different value IIUC.
>
I don't think that getting a different value in SMBIOS tables after reboot
is problematic. It may change on real HW too I think. Because of power
saving on a laptop for instance.

> Also, instead of returning 0 on non-linux systems, why not just return  
> some fixed value?  It's no more "wrong" than returning the host clock 
> rate.
>
I am OK with that. What value do you propose?

I'll resent a whole series. Let's move discussion there. And if there is
no more comments about other parts of the series can we apply it finally?

--
			Gleb.