From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] [PATCH]: Display TCGCond name in tcg dumper
Date: Tue, 9 Sep 2008 18:00:12 +0100 [thread overview]
Message-ID: <200809091800.12761.paul@codesourcery.com> (raw)
In-Reply-To: <f43fc5580809090854l7995557bof23fecef91b8ae0c@mail.gmail.com>
> > currently TCGCond are displayed by value in tcg dumps - which is not
> > very easy to read.
> > This patch displays names instead.
>
> The brconds look much better with your patch. Anybody mind if I apply this?
It's a bit of an ugly hack. However I can't immediately see a cleaner
solution.
> fprintf(outfile, ",%s", cond_name[args[k++]]);
This needs bounds checking in case we generate a bogus condition.
Other than that, ok.
Paul
next prev parent reply other threads:[~2008-09-09 17:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-08 13:32 [Qemu-devel] [PATCH]: Display TCGCond name in tcg dumper Tristan Gingold
2008-09-09 15:54 ` Blue Swirl
2008-09-09 17:00 ` Paul Brook [this message]
2008-09-10 7:45 ` Tristan Gingold
2008-09-10 7:58 ` Tristan Gingold
2008-09-14 7:49 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200809091800.12761.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).