From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Kd6Zg-0001G7-GS for qemu-devel@nongnu.org; Tue, 09 Sep 2008 13:00:20 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Kd6Zf-0001Dh-57 for qemu-devel@nongnu.org; Tue, 09 Sep 2008 13:00:20 -0400 Received: from [199.232.76.173] (port=36817 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kd6Ze-0001DH-S9 for qemu-devel@nongnu.org; Tue, 09 Sep 2008 13:00:18 -0400 Received: from mail.codesourcery.com ([65.74.133.4]:38406) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Kd6Zd-000764-UH for qemu-devel@nongnu.org; Tue, 09 Sep 2008 13:00:18 -0400 From: Paul Brook Subject: Re: [Qemu-devel] [PATCH]: Display TCGCond name in tcg dumper Date: Tue, 9 Sep 2008 18:00:12 +0100 References: <7C48730E-3B65-4548-B6DF-FF2A2A5A6E6A@adacore.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200809091800.12761.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Blue Swirl > > currently TCGCond are displayed by value in tcg dumps - which is not > > very easy to read. > > This patch displays names instead. > > The brconds look much better with your patch. Anybody mind if I apply this? It's a bit of an ugly hack. However I can't immediately see a cleaner solution. > fprintf(outfile, ",%s", cond_name[args[k++]]); This needs bounds checking in case we generate a bogus condition. Other than that, ok. Paul