From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KdMVy-0006D6-H1 for qemu-devel@nongnu.org; Wed, 10 Sep 2008 06:01:34 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KdMVx-0006CM-Hu for qemu-devel@nongnu.org; Wed, 10 Sep 2008 06:01:33 -0400 Received: from [199.232.76.173] (port=41696 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KdMVx-0006C7-9w for qemu-devel@nongnu.org; Wed, 10 Sep 2008 06:01:33 -0400 Received: from mx1.redhat.com ([66.187.233.31]:53348) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KdMVx-00018m-4Y for qemu-devel@nongnu.org; Wed, 10 Sep 2008 06:01:33 -0400 Date: Wed, 10 Sep 2008 11:01:27 +0100 From: "Daniel P. Berrange" Subject: Re: [Qemu-devel] [PATCH 2/10] Allow the monitor to be suspended during non-blocking op Message-ID: <20080910100127.GD2662@redhat.com> References: <1220989802-13706-1-git-send-email-aliguori@us.ibm.com> <1220989802-13706-3-git-send-email-aliguori@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1220989802-13706-3-git-send-email-aliguori@us.ibm.com> Reply-To: "Daniel P. Berrange" , qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Chris Wright , Uri Lublin , Anthony Liguori , kvm@vger.kernel.org On Tue, Sep 09, 2008 at 02:49:54PM -0500, Anthony Liguori wrote: > Live migration happens in the background, but it is useful to make the monitor > command appear as if it's blocking. This allows a management tool to > immediately know when the live migration has completed without having to poll > the migration status. > > This patch allows the monitor to be suspended from a monitor callback which > will prevent new monitor commands from being executed. If I'm understanding this correctly, this will cause the monitor to silently drop & ignore any commands issued ? Might it be better to have it print a reply on the monitor along the lines of 'command not allowed while migration is in progress' so people/apps interacting with the monitor understand why it is not doing what they ask it to. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|