From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KdmhS-0008FZ-8V for qemu-devel@nongnu.org; Thu, 11 Sep 2008 09:59:10 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KdmhN-0008D5-Ly for qemu-devel@nongnu.org; Thu, 11 Sep 2008 09:59:09 -0400 Received: from [199.232.76.173] (port=45717 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KdmhN-0008D0-Gk for qemu-devel@nongnu.org; Thu, 11 Sep 2008 09:59:05 -0400 Received: from mail.codesourcery.com ([65.74.133.4]:42574) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KdmhM-0006Sl-Eb for qemu-devel@nongnu.org; Thu, 11 Sep 2008 09:59:04 -0400 From: Paul Brook Subject: Re: [Qemu-devel] [PATCH] Don't use QEMU_VERSION in ATA/ATAPI replies to IDENTIFY cmds Date: Thu, 11 Sep 2008 14:58:55 +0100 References: <5d6222a80809110444t75ec91fau15d8aaaaa7ea4173@mail.gmail.com> <20080911115629.GA16427@shareable.org> In-Reply-To: <20080911115629.GA16427@shareable.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200809111458.57906.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org > Bug fixes and performance improvements are fine. The whole point of the drive firmware version is that it's supposed to change every time bug fixes and performance improvements are made. I'm pretty sure it'll also change when you upgrade the firmware on a real drive. As far as I'm concerned anything that relies on this value being constant over qemu is just plain broken. Paul