From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KeFkm-0008Sr-RA for qemu-devel@nongnu.org; Fri, 12 Sep 2008 17:00:32 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KeFkk-0008Oz-MR for qemu-devel@nongnu.org; Fri, 12 Sep 2008 17:00:31 -0400 Received: from [199.232.76.173] (port=37304 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KeFkk-0008OS-33 for qemu-devel@nongnu.org; Fri, 12 Sep 2008 17:00:30 -0400 Received: from bsdimp.com ([199.45.160.85]:61376 helo=harmony.bsdimp.com) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KeFki-00022Z-Ki for qemu-devel@nongnu.org; Fri, 12 Sep 2008 17:00:29 -0400 Date: Fri, 12 Sep 2008 14:59:26 -0600 (MDT) Message-Id: <20080912.145926.10073272.imp@bsdimp.com> Subject: Re: [Qemu-devel] [PATCH][RFC] Fix gcc 4.x warnings (-Wpointer-sign) From: "M. Warner Losh" In-Reply-To: References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, blauwirbel@gmail.com In message: "Blue Swirl" writes: : GCC 4 enables -Wpointer-sign if -Wall is enabled. This trivial patch : suppresses the warnings. Comments? Objections? Don't you mean 'fix' the warnings, since this patch looks like it tries to cast things to be correct... Warner