From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KeGVg-00089H-JE
	for qemu-devel@nongnu.org; Fri, 12 Sep 2008 17:49:00 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KeGVc-00088k-2h
	for qemu-devel@nongnu.org; Fri, 12 Sep 2008 17:49:00 -0400
Received: from [199.232.76.173] (port=54647 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KeGVb-00088h-Tc
	for qemu-devel@nongnu.org; Fri, 12 Sep 2008 17:48:55 -0400
Received: from mx2.redhat.com ([66.187.237.31]:45154)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <ehabkost@redhat.com>) id 1KeGVb-0001Ml-BP
	for qemu-devel@nongnu.org; Fri, 12 Sep 2008 17:48:55 -0400
Date: Fri, 12 Sep 2008 18:47:04 -0300
From: Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [Qemu-devel] Re: [PATCH] Make page_find() return 0 for
	too-large addresses
Message-ID: <20080912214704.GC10147@blackpad>
References: <20080912185856.GM3982@blackpad> <48CAC809.5000901@codemonkey.ws>
	<20080912201406.GA10147@blackpad> <20080912204404.GB10147@blackpad>
	<48CADEC2.3060204@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <48CADEC2.3060204@codemonkey.ws>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, gcosta@redhat.com

On Fri, Sep 12, 2008 at 04:27:30PM -0500, Anthony Liguori wrote:
> Eduardo Habkost wrote:
>> On Fri, Sep 12, 2008 at 05:14:06PM -0300, Eduardo Habkost wrote:
>>   
>>> On Fri, Sep 12, 2008 at 02:50:33PM -0500, Anthony Liguori wrote:
>>>     
>>>> Eduardo Habkost wrote:
>>>>       
>>>>> On some cases, such as under KVM, tb_invalidate_phys_page_range()
>>>>> may be called for large addresses, when qemu is configured to more than
>>>>> 4GB of RAM.
>>>>>
>>>>> On these cases, qemu was crashing because it was using an index too
>>>>> large for l1_map[], that supports only 32-bit addresses when compiling
>>>>> without CONFIG_USER_ONLY.
>>>>>           
>> <snip>
>>   
>
> So... are you building with kqemu enabled?

No, as I've stated in the reply I've sent before the patch.


> If so,  
> TARGET_PHYS_ADDR_SPACE_BITS will be 32.  So I don't think this sort of  
> work-around is correct.  A better solution would be to validate ram_size  
> against TARGET_PHYS_ADDR_SPACE_BITS.

This is a good idea (maybe it is already checked?), but it is not the
case I am dealing with.


>
> To put it another way, if you have kqemu enabled (at build time), you  
> cannot use > ~4GB of memory for the guest.

Right.

-- 
Eduardo