From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: "Blue Swirl" <blauwirbel@gmail.com>,
"Andreas Färber" <andreas.faerber@web.de>,
"Aurelien Jarno" <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH 2/2] ppc: Convert op_andi to TCG
Date: Sun, 14 Sep 2008 13:03:26 +0100 [thread overview]
Message-ID: <200809141303.27871.paul@codesourcery.com> (raw)
In-Reply-To: <f43fc5580809140453kba71efar20d4a00a90d3bc26@mail.gmail.com>
> > > > tcg_gen_mov_tl(cpu_T[0], cpu_gpr[rS(ctx->opcode)]);
> > > > - gen_op_andi_T0(UIMM(ctx->opcode));
> > > > + tcg_gen_andi_tl(cpu_T[0], cpu_T[0], UIMM(ctx->opcode));
> > > > tcg_gen_mov_tl(cpu_gpr[rA(ctx->opcode)], cpu_T[0]);
> > > > gen_set_Rc0(ctx);
> > > > }
> > >
> > > Small comment: this would be more optimally:
> > > tcg_gen_andi_tl(cpu_gpr[rA(ctx->opcode)],
> > > cpu_gpr[rS(ctx->opcode)], UIMM(ctx->opcode));
> > >
> > > The same applies to andis.
> >
> > Careful there, iirc this cannot be done before gen_set_Rc0 is converted!
>
> I didn't mean to remove gen_set_Rc0, the comment only applied to the
> mov+andi+mov sequence.
set_Rc0 relies on T0 being set correctly be the preceding sequence.
Paul
next prev parent reply other threads:[~2008-09-14 12:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-14 11:06 [Qemu-devel] [PATCH 1/2] ppc: Convert ctr, lr moves to TCG Andreas Färber
2008-09-14 11:23 ` [Qemu-devel] [PATCH 2/2] ppc: Convert op_andi " Andreas Färber
2008-09-14 11:35 ` Blue Swirl
2008-09-14 11:48 ` Andreas Färber
2008-09-14 11:53 ` Blue Swirl
2008-09-14 12:02 ` Andreas Färber
2008-09-14 12:03 ` Paul Brook [this message]
2008-09-14 12:13 ` Blue Swirl
2008-09-14 18:34 ` Aurelien Jarno
2008-09-14 18:30 ` [Qemu-devel] [PATCH 1/2] ppc: Convert ctr, lr moves " Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200809141303.27871.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=andreas.faerber@web.de \
--cc=aurelien@aurel32.net \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).