Re: [Qemu-devel] [PATCH 1/1][RESEND] v2: Fix text console size/resize when using curses

[Ryan Harper <ryanh@us.ibm.com>]

* andrzej zaborowski <balrogg@gmail.com> [2008-09-15 11:51]:
> Hi,

Hello,

> 
> 2008/9/4 Ryan Harper <ryanh@us.ibm.com>:
> > v2: drop initial size adjustment, not needed.
> >
> > Resize events fail to ensure that both the text console and curses display areas
> > are the same size; this causes broken output like:
> 
> It seems that this was broken by r4812.  Your patch looks correct but

Thanks for taking a look,

> I think it will prevent things like -serial vc:80Cx24C from working as
> documented. There's a conflict here: either virtual consoles have
> commandline-set fixed size or they adjust to the window size like
> before r4812 and don't have parts that don't fit on the screen. The
> SDL window is not resizable but the curses window is always resizable.
>  I propose to add TEXT_CONSOLE_FIXED_SIZE back, it was removed by
> r4812.  I will do this unless there are better ideas.

I'll test the -serial to see if that breaks with the current patch..
I'm also looking at an alternative.  I think that in curses.c if on
window change event we can send a qemu_console_resize() to the text
consoles with the new width,height, that does the work of getting the
width/height in sync.  I'll send an update if I get that working.

> 
> Another idea would be to set the default console size to 640x400 and
> agree to not support terminals < 80x24.

I'm not sure that would fix it completely, I'm pretty sure the output
still looks broken even if your terminal is bigger than the min size
required.

> 
> Regards
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
(512) 838-9253   T/L: 678-9253
ryanh@us.ibm.com