From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KfI18-0008AY-1d for qemu-devel@nongnu.org; Mon, 15 Sep 2008 13:37:42 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KfI15-00089t-8o for qemu-devel@nongnu.org; Mon, 15 Sep 2008 13:37:41 -0400 Received: from [199.232.76.173] (port=42503 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KfI15-00089p-4H for qemu-devel@nongnu.org; Mon, 15 Sep 2008 13:37:39 -0400 Received: from e34.co.us.ibm.com ([32.97.110.152]:43004) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KfI14-000614-Ls for qemu-devel@nongnu.org; Mon, 15 Sep 2008 13:37:38 -0400 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e34.co.us.ibm.com (8.13.8/8.13.8) with ESMTP id m8FHZN7Q018479 for ; Mon, 15 Sep 2008 13:35:23 -0400 Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id m8FHZIU9196016 for ; Mon, 15 Sep 2008 11:35:22 -0600 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m8FHZIku025924 for ; Mon, 15 Sep 2008 11:35:18 -0600 Date: Mon, 15 Sep 2008 12:35:03 -0500 From: Ryan Harper Subject: Re: [Qemu-devel] [PATCH 1/1][RESEND] v2: Fix text console size/resize when using curses Message-ID: <20080915173503.GT17312@us.ibm.com> References: <1220544638-1972-1-git-send-email-ryanh@us.ibm.com> <1220544638-1972-2-git-send-email-ryanh@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: andrzej zaborowski Cc: Paul Brook , Ryan Harper , qemu-devel@nongnu.org, kvm@vger.kernel.org, Ian Kirk * andrzej zaborowski [2008-09-15 11:51]: > Hi, Hello, > > 2008/9/4 Ryan Harper : > > v2: drop initial size adjustment, not needed. > > > > Resize events fail to ensure that both the text console and curses display areas > > are the same size; this causes broken output like: > > It seems that this was broken by r4812. Your patch looks correct but Thanks for taking a look, > I think it will prevent things like -serial vc:80Cx24C from working as > documented. There's a conflict here: either virtual consoles have > commandline-set fixed size or they adjust to the window size like > before r4812 and don't have parts that don't fit on the screen. The > SDL window is not resizable but the curses window is always resizable. > I propose to add TEXT_CONSOLE_FIXED_SIZE back, it was removed by > r4812. I will do this unless there are better ideas. I'll test the -serial to see if that breaks with the current patch.. I'm also looking at an alternative. I think that in curses.c if on window change event we can send a qemu_console_resize() to the text consoles with the new width,height, that does the work of getting the width/height in sync. I'll send an update if I get that working. > > Another idea would be to set the default console size to 640x400 and > agree to not support terminals < 80x24. I'm not sure that would fix it completely, I'm pretty sure the output still looks broken even if your terminal is bigger than the min size required. > > Regards > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin, Tx (512) 838-9253 T/L: 678-9253 ryanh@us.ibm.com