[Qemu-devel] [PATCH] add inotify syscalls

[Qemu-devel] [PATCH] add inotify syscalls

[Riku Voipio]

[-- Attachment #1.1: Type: text/plain, Size: 166 bytes --]

Inotify syscall implementation lifted from scratchbox.

Signed-off-by: Riku Voipio <riku.voipio@iki.fi>
-- 
"rm -rf" only sounds scary if you don't have backups

[-- Attachment #1.2: 97_inotify.patch --]
[-- Type: text/plain, Size: 1139 bytes --]

Index: trunk/linux-user/syscall.c
===================================================================
--- trunk.orig/linux-user/syscall.c	2008-09-17 22:08:51.000000000 +0300
+++ trunk/linux-user/syscall.c	2008-09-17 22:12:04.000000000 +0300
@@ -29,6 +29,7 @@
 #include <time.h>
 #include <limits.h>
 #include <sys/types.h>
+#include <sys/inotify.h>
 #include <sys/ipc.h>
 #include <sys/msg.h>
 #include <sys/wait.h>
@@ -5821,7 +5822,23 @@
         ret = do_futex(arg1, arg2, arg3, arg4, arg5, arg6);
         break;
 #endif
-
+#ifdef TARGET_NR_inotify_init
+    case TARGET_NR_inotify_init:
+        ret = get_errno(inotify_init());
+        break;
+#endif
+#ifdef TARGET_NR_inotify_add_watch
+    case TARGET_NR_inotify_add_watch:
+        p = lock_user_string(arg2);
+        ret = get_errno(inotify_add_watch(arg1, path(p), arg3));
+        unlock_user(p, arg2, 0);
+        break;
+#endif
+#ifdef TARGET_NR_inotify_rm_watch
+    case TARGET_NR_inotify_rm_watch:
+        ret = get_errno(inotify_rm_watch(arg1, arg2));
+        break;
+#endif
     default:
     unimplemented:
         gemu_log("qemu: Unsupported syscall: %d\n", num);

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [Qemu-devel] [PATCH] add inotify syscalls

[Kirill A. Shutemov]

[-- Attachment #1: Type: text/plain, Size: 1705 bytes --]

On Wed, Sep 17, 2008 at 10:45:50PM +0300, Riku Voipio wrote:
> Inotify syscall implementation lifted from scratchbox.
> 
> Signed-off-by: Riku Voipio <riku.voipio@iki.fi>
> -- 
> "rm -rf" only sounds scary if you don't have backups

> Index: trunk/linux-user/syscall.c
> ===================================================================
> --- trunk.orig/linux-user/syscall.c	2008-09-17 22:08:51.000000000 +0300
> +++ trunk/linux-user/syscall.c	2008-09-17 22:12:04.000000000 +0300
> @@ -29,6 +29,7 @@
>  #include <time.h>
>  #include <limits.h>
>  #include <sys/types.h>
> +#include <sys/inotify.h>
>  #include <sys/ipc.h>
>  #include <sys/msg.h>
>  #include <sys/wait.h>
> @@ -5821,7 +5822,23 @@
>          ret = do_futex(arg1, arg2, arg3, arg4, arg5, arg6);
>          break;
>  #endif
> -
> +#ifdef TARGET_NR_inotify_init
> +    case TARGET_NR_inotify_init:
> +        ret = get_errno(inotify_init());
> +        break;
> +#endif
> +#ifdef TARGET_NR_inotify_add_watch
> +    case TARGET_NR_inotify_add_watch:
> +        p = lock_user_string(arg2);
> +        ret = get_errno(inotify_add_watch(arg1, path(p), arg3));
> +        unlock_user(p, arg2, 0);
> +        break;
> +#endif
> +#ifdef TARGET_NR_inotify_rm_watch
> +    case TARGET_NR_inotify_rm_watch:
> +        ret = get_errno(inotify_rm_watch(arg1, arg2));
> +        break;
> +#endif
>      default:
>      unimplemented:
>          gemu_log("qemu: Unsupported syscall: %d\n", num);


This syscalls like *at introduced in glibc 2.4. So you should use
_syscall* macros for backward compatible.

-- 
Regards,  Kirill A. Shutemov
 + Belarus, Minsk
 + ALT Linux Team, http://www.altlinux.com/

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: [Qemu-devel] [PATCH] add inotify syscalls

[Riku Voipio]

On Fri, Sep 19, 2008 at 11:08:07AM +0300, Kirill A. Shutemov wrote:
> On Wed, Sep 17, 2008 at 10:45:50PM +0300, Riku Voipio wrote:
> > Inotify syscall implementation lifted from scratchbox.
> > 
> > Signed-off-by: Riku Voipio <riku.voipio@iki.fi>
> > -- 
> > "rm -rf" only sounds scary if you don't have backups
> 
> > Index: trunk/linux-user/syscall.c
> > ===================================================================
> > --- trunk.orig/linux-user/syscall.c	2008-09-17 22:08:51.000000000 +0300
> > +++ trunk/linux-user/syscall.c	2008-09-17 22:12:04.000000000 +0300
> > @@ -29,6 +29,7 @@
> >  #include <time.h>
> >  #include <limits.h>
> >  #include <sys/types.h>
> > +#include <sys/inotify.h>
> >  #include <sys/ipc.h>
> >  #include <sys/msg.h>
> >  #include <sys/wait.h>
> > @@ -5821,7 +5822,23 @@
> >          ret = do_futex(arg1, arg2, arg3, arg4, arg5, arg6);
> >          break;
> >  #endif
> > -
> > +#ifdef TARGET_NR_inotify_init
> > +    case TARGET_NR_inotify_init:
> > +        ret = get_errno(inotify_init());
> > +        break;
> > +#endif
> > +#ifdef TARGET_NR_inotify_add_watch
> > +    case TARGET_NR_inotify_add_watch:
> > +        p = lock_user_string(arg2);
> > +        ret = get_errno(inotify_add_watch(arg1, path(p), arg3));
> > +        unlock_user(p, arg2, 0);
> > +        break;
> > +#endif
> > +#ifdef TARGET_NR_inotify_rm_watch
> > +    case TARGET_NR_inotify_rm_watch:
> > +        ret = get_errno(inotify_rm_watch(arg1, arg2));
> > +        break;
> > +#endif
> >      default:
> >      unimplemented:
> >          gemu_log("qemu: Unsupported syscall: %d\n", num);
> 
> 
> This syscalls like *at introduced in glibc 2.4. So you should use
> _syscall* macros for backward compatible.

Right, will fix in a moment


-- 
"rm -rf" only sounds scary if you don't have backups