[Qemu-devel] [PATCH] alpha: fix a missing literal sign issue

[Qemu-devel] [PATCH] alpha: fix a missing literal sign issue

[Tristan Gingold]

[-- Attachment #1: Type: text/plain, Size: 166 bytes --]

Hi,

I suppose this chunk was lot in translation, but literals in  
instructions are always unsigned.

Tristan.

Signed-off-by: Tristan Gingold <gingold@adacore.com>

[-- Attachment #2: q-alpha10.diff --]
[-- Type: application/octet-stream, Size: 540 bytes --]

Index: target-alpha/translate.c
===================================================================
--- target-alpha/translate.c	(revision 5247)
+++ target-alpha/translate.c	(working copy)
@@ -390,7 +390,7 @@
 static always_inline void gen_cmov (DisasContext *ctx,
                                     TCGCond inv_cond,
                                     int ra, int rb, int rc,
-                                    int islit, int8_t lit, int mask)
+                                    int islit, uint8_t lit, int mask)
 {
     int l1;
 

Re: [Qemu-devel] [PATCH] alpha: fix a missing literal sign issue

[Aurelien Jarno]

On Thu, Sep 18, 2008 at 10:11:02AM +0200, Tristan Gingold wrote:
> Hi,
>
> I suppose this chunk was lot in translation, but literals in  
> instructions are always unsigned.

The problem is that lit is wrongly defined to int8_t in translate_one().
I have applied your patch, and fixed a few other wrong places. Thanks.

> Tristan.
>
> Signed-off-by: Tristan Gingold <gingold@adacore.com>



-- 
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   aurel32@debian.org         | aurelien@aurel32.net
   `-    people.debian.org/~aurel32 | www.aurel32.net