From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KgFnj-0008F0-GH for qemu-devel@nongnu.org; Thu, 18 Sep 2008 05:27:51 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KgFnh-0008EB-IX for qemu-devel@nongnu.org; Thu, 18 Sep 2008 05:27:51 -0400 Received: from [199.232.76.173] (port=40292 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KgFnh-0008E3-A3 for qemu-devel@nongnu.org; Thu, 18 Sep 2008 05:27:49 -0400 Received: from ey-out-1920.google.com ([74.125.78.147]:10669) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KgFnh-0000Vf-Sl for qemu-devel@nongnu.org; Thu, 18 Sep 2008 05:27:50 -0400 Received: by ey-out-1920.google.com with SMTP id 4so1467463eyk.4 for ; Thu, 18 Sep 2008 02:27:47 -0700 (PDT) Date: Thu, 18 Sep 2008 12:28:31 +0300 From: "Kirill A. Shutemov" Subject: Re: [Qemu-devel] [PATCH] add futimesat syscall Message-ID: <20080918092826.GA5059@localhost.localdomain> References: <20080917194533.GB21187@kos.to> <20080918063007.GA26841@kos.to> <761ea48b0809180023t37d300ceq790fe33c5ab7602a@mail.gmail.com> <20080918090821.GA17893@kos.to> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="cWoXeonUoKmBZSoM" Content-Disposition: inline In-Reply-To: <20080918090821.GA17893@kos.to> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Riku Voipio Cc: qemu-devel@nongnu.org --cWoXeonUoKmBZSoM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 18, 2008 at 12:08:21PM +0300, Riku Voipio wrote: > On Thu, Sep 18, 2008 at 09:23:20AM +0200, Laurent Desnogues wrote: > > On Thu, Sep 18, 2008 at 8:30 AM, Riku Voipio wrote: > > > On Thu, Sep 18, 2008 at 01:54:21AM +0200, andrzej zaborowski wrote: >=20 > > >> http://lists.gnu.org/archive/html/qemu-devel/2008-09/msg00439.html , > > >> it looks cleaner to me. >=20 > > > Kirill's patch looks good to me. >=20 > > There's a functional difference between Kirill's patch and yours: >=20 > > Kirill + ret =3D get_errno(futimesat(arg1, p, tvp)); > > you + ret =3D get_errno(sys_futimesat(arg1, path(p), t= v)); >=20 > The sbox patch defines sys_futimesat earlier in the file, presumably to > deal with supporting a stone-age version of libc/kernel headers. I don't think that it's great idea. If libc/kernel headers doesn't provide the syscall we shouldn't implement them. The exception is syscalls without libc's wrapper. Like gettid(2). > path() is related to interp_prefix. The old utimes handlers don't use > path() either, and it's unlikely that any library-loading routine uses > futimes(). Thus, I believe Kirill's version is more correct. I have written futimeat based on utimes(). If utimes() emulation work=20 properly with interp_prefix !=3D "/", futimesat() also will. But I have never test it with interp_prefix !=3D "/" --=20 Regards, Kirill A. Shutemov + Belarus, Minsk + ALT Linux Team, http://www.altlinux.com/ --cWoXeonUoKmBZSoM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEARECAAYFAkjSHzoACgkQbWYnhzC5v6rwdQCbB6Sg5PjFIbrH7OPqvAeS19Fq pfAAnil51rhZ758o/S/X2v+yA+840CIV =s0Bi -----END PGP SIGNATURE----- --cWoXeonUoKmBZSoM--